Create FatalInternalGlobalizationError and make the failfast trigger in ChakraCore.

Author: dilijev

lib/Common/Exceptions/Throw.cpp

@@ -77,6 +77,13 @@ namespace Js {
         ReportFatalException(NULL, E_FAIL, Fatal_Internal_Error, scenario);
     }
 
+    void Throw::FatalInternalGlobalizationError()
+    {
+        AssertMsg(false, "Failure in initializing Globalization library");
+        int scenario = 2;
+        ReportFatalException(NULL, E_FAIL, Fatal_Internal_Error, scenario);
+    }
+
     void Throw::FatalProjectionError()
     {
         RaiseException((DWORD)DBG_TERMINATE_PROCESS, EXCEPTION_NONCONTINUABLE, 0, NULL);

lib/Common/Exceptions/Throw.h

@@ -21,6 +21,8 @@ namespace Js {
         static void __declspec(noreturn) InternalError();
         static void __declspec(noreturn) FatalInternalError();
         static void __declspec(noreturn) FatalInternalErrorEx(int scenario);
+        static void __declspec(noreturn) FatalInternalGlobalizationError();
+
         static void __declspec(noreturn) FatalProjectionError();
 #if ENABLE_JS_REENTRANCY_CHECK
         static void __declspec(noreturn) FatalJsReentrancyError();

lib/Parser/CharClassifier.cpp

@@ -411,13 +411,11 @@ Js::CharClassifier::CharClassifier(void)
     bool isES6UnicodeModeEnabled = CONFIG_FLAG(ES6Unicode);
     bool isFullUnicodeSupportAvailable = PlatformAgnostic::UnicodeText::IsExternalUnicodeLibraryAvailable();
 
-#ifdef NTBUILD
     AssertMsg(isFullUnicodeSupportAvailable, "Windows.Globalization needs to present with IUnicodeCharacterStatics support for Chakra.dll to work");
     if (!isFullUnicodeSupportAvailable)
     {
-        Js::Throw::FatalInternalError();
+        Js::Throw::FatalInternalGlobalizationError();
     }
-#endif
 
     // If we're in ES6 mode, and we have full support for Unicode character classification
     // from an external library, then use the ES6/Surrogate pair supported versions of the functions
@@ -450,7 +448,6 @@ Js::CharClassifier::CharClassifier(void)
         getBigCharFlagsFunc = &CharClassifier::GetBigCharFlagsES5;
     }
 #endif
-
 }
 
 const OLECHAR* Js::CharClassifier::SkipWhiteSpaceNonSurrogate(LPCOLESTR psz, const CharClassifier *instance)

lib/Runtime/PlatformAgnostic/Platform/Windows/UnicodeText.cpp

@@ -408,18 +408,16 @@ namespace PlatformAgnostic
                     {
                         return true;
                     }
-#ifdef NTBUILD
                     else
                     {
                         // did not find winGlobCharApi
-                        Js::Throw::FatalInternalError();
+                        Js::Throw::FatalInternalGlobalizationError();
                     }
                 }
                 else
                 {
                     // failed to initialize Windows Globalization
-                    Js::Throw::FatalInternalError();
-#endif
+                    Js::Throw::FatalInternalGlobalizationError();
                 }
 
                 return false;