Skip to content

Commit b2f092e

Browse files
MSLaguanaAtul Katti
authored andcommitted
[CVE-2018-8283] Edge - ChakraCore Memory Corruption - Individual
1 parent c322694 commit b2f092e

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

lib/Runtime/Types/PathTypeHandler.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1452,7 +1452,11 @@ namespace Js
14521452
DictionaryPropertyDescriptor<PropertyIndex> *descriptor;
14531453
bool result = newTypeHandler->propertyMap->TryGetReference(propertyRecord, &descriptor);
14541454
Assert(result);
1455-
Assert(attributes[descriptor->GetDataPropertyIndex<false>()] & ObjectSlotAttr_Accessor);
1455+
if (!(attributes[descriptor->GetDataPropertyIndex<false>()] & ObjectSlotAttr_Accessor))
1456+
{
1457+
// Setter without a getter; this is a stale entry, so ignore it
1458+
continue;
1459+
}
14561460
Assert(oldTypeHandler->GetSetterSlotIndex(descriptor->GetDataPropertyIndex<false>()) == newTypeHandler->nextPropertyIndex);
14571461
descriptor->ConvertToGetterSetter(newTypeHandler->nextPropertyIndex);
14581462
newTypeHandler->ClearHasOnlyWritableDataProperties();

0 commit comments

Comments
 (0)