[MERGE #5244 @sigatrev] OS#17382750 avoid recollecting callback inlinee data for recursive calls

Merge pull request #5244 from sigatrev:recursiveCallback

Author: sigatrev

lib/Backend/NativeCodeGenerator.cpp

@@ -2919,26 +2919,29 @@ NativeCodeGenerator::GatherCodeGenData(
 
             if (PHASE_ENABLED(InlineCallbacksPhase, functionBody))
             {
-                Js::FunctionInfo *const callbackInfo = inliningDecider.InlineCallback(functionBody, profiledCallSiteId, recursiveInlineDepth);
-                if (callbackInfo != nullptr)
+                if (!isJitTimeDataComputed)
                 {
-                    Js::FunctionBody *const callbackBody = callbackInfo->GetFunctionBody();
-                    if (callbackBody != nullptr && callbackBody != functionBody)
+                    Js::FunctionInfo *const callbackInfo = inliningDecider.InlineCallback(functionBody, profiledCallSiteId, recursiveInlineDepth);
+                    if (callbackInfo != nullptr)
                     {
-                        Js::FunctionCodeGenJitTimeData * callbackJitTimeData = jitTimeData->AddCallbackInlinee(recycler, profiledCallSiteId, callbackInfo);
-                        Js::FunctionCodeGenRuntimeData * callbackRuntimeData = IsInlinee ? runtimeData->EnsureCallbackInlinee(recycler, profiledCallSiteId, callbackBody) : functionBody->EnsureCallbackInlineeCodeGenRuntimeData(recycler, profiledCallSiteId, callbackBody);
-
-                        GatherCodeGenData<true>(
-                            recycler,
-                            topFunctionBody,
-                            callbackBody,
-                            entryPoint,
-                            inliningDecider,
-                            objTypeSpecFldInfoList,
-                            callbackJitTimeData,
-                            callbackRuntimeData);
-
-                        AddInlineCacheStats(jitTimeData, callbackJitTimeData);
+                        Js::FunctionBody *const callbackBody = callbackInfo->GetFunctionBody();
+                        if (callbackBody != nullptr && callbackBody != functionBody)
+                        {
+                            Js::FunctionCodeGenJitTimeData * callbackJitTimeData = jitTimeData->AddCallbackInlinee(recycler, profiledCallSiteId, callbackInfo);
+                            Js::FunctionCodeGenRuntimeData * callbackRuntimeData = IsInlinee ? runtimeData->EnsureCallbackInlinee(recycler, profiledCallSiteId, callbackBody) : functionBody->EnsureCallbackInlineeCodeGenRuntimeData(recycler, profiledCallSiteId, callbackBody);
+
+                            GatherCodeGenData<true>(
+                                recycler,
+                                topFunctionBody,
+                                callbackBody,
+                                entryPoint,
+                                inliningDecider,
+                                objTypeSpecFldInfoList,
+                                callbackJitTimeData,
+                                callbackRuntimeData);
+
+                            AddInlineCacheStats(jitTimeData, callbackJitTimeData);
+                        }
                     }
                 }
             }

test/inlining/recursiveCallbacks.js

@@ -0,0 +1,18 @@
+//-------------------------------------------------------------------------------------------------------
+// Copyright (C) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
+//-------------------------------------------------------------------------------------------------------
+
+function r(t) {
+    if (!(this instanceof r)) {
+        return new r(t);
+    }
+}
+
+function foo() {}
+
+r(foo);
+r(foo);
+r(foo);
+
+WScript.Echo("Passed");

test/inlining/rlexe.xml

@@ -302,4 +302,9 @@
       <tags>exclude_dynapogo,exclude_nonative,exclude_forceserialized,require_backend</tags>
     </default>
   </test>
+  <test>
+    <default>
+      <files>recursiveCallbacks.js</files>
+    </default>
+  </test>
 </regress-exe>