Merged
Conversation
ShortDevelopment
force-pushed
the
refactor/cpp-14
branch
from
32210ef to
72bca60
Compare
Collaborator
|
Is this the next one to merge? Please can you update the branch for me having merged the last one? |
ShortDevelopment
force-pushed
the
refactor/cpp-14
branch
from
72bca60 to
43c6cf1
Compare
Contributor
Author
Yes. This should hopefully be just a formallity as I already build CC with c++14 on my local Windows device.
Done 😊 |
Collaborator
|
I think we should put an "exclude x86" tag on that typed array memory test it's been flaky for ages not because of any bug in CC but (I think) simply because the x86 test environment doesn't have enough memory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My install of VisualStudio already uses c++14 to compile CC.
Update CMake project to use c++14 aswell.
💥 Breaking changes
pal/inc/rt/sal.hand/include/c++/12/bits/parse_numbers.h⇾
#undef __valid✅ This PR is stacked onto #7040.