Conversation
… Android. - Improved `detectBiometricTypes` to use system resources and reflection for more accurate identification of face, fingerprint, and iris sensors. - Added a `matchesLabel` utility for better matching of localized biometric strings, including support for CJK characters. - Refactored `BiometricSignaturePlugin.kt` with consistent indentation and improved code structure. - Replaced `FingerprintManager` with `Resources` for system-level string lookups. - Updated error handling and callback structures to be more robust.
…ith recent Flutter updates.
|
@codex, please review |
|
To use Codex here, create a Codex account and connect to github. |
|
@codex, review now. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d2c2b3fc9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (buttonLabel == null || terms.isEmpty()) return false | ||
| return terms.any { term -> |
There was a problem hiding this comment.
detectBiometricTypes() now relies on matchesLabel for every biometric type, but matchesLabel returns false when buttonLabel is null and the reflection block that fills buttonLabel explicitly ignores failures. In environments where BiometricManager.getStrings(...) is unavailable or OEM/localized text does not match the term lists, biometricAuthAvailable() can return canAuthenticate = true with availableBiometrics = [], which regresses previous behavior that still returned a fallback type (BiometricType.MULTIPLE) and can cause clients to mis-handle available biometrics.
Useful? React with 👍 / 👎.
…hing with a feature-backed fallback and enhancing null/blank label checks.
1 participant
feat: Add Swift Package Manager support for iOS and macOS.
feat: enhance biometric type detection and improve code formatting on Android.