Skip to content

chore: upgrade to bloodhound 0.26.0.0#1178

Merged
morucci merged 15 commits intochange-metrics:masterfrom
blackheaven:chore/bloodhound-025
Nov 18, 2025
Merged

chore: upgrade to bloodhound 0.26.0.0#1178
morucci merged 15 commits intochange-metrics:masterfrom
blackheaven:chore/bloodhound-025

Conversation

@blackheaven
Copy link
Contributor

I did not run the tests or the project.

Copy link
Contributor

@TristanCacqueray TristanCacqueray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blackheaven thanks a lot, we meant to do this upgrade for a while!

Aeson.FromJSON a =>
BH.IndexName ->
body ->
m [Json.Value]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, aeson is too slow for certain query, so we do need to keep json-syntax here. See: the test/JsonDecode.{hs,py} benchmark.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted!

@blackheaven blackheaven force-pushed the chore/bloodhound-025 branch from 38fa901 to e33b731 Compare October 8, 2025 20:50
@blackheaven
Copy link
Contributor Author

Not sure why it cannot parse id anymore...

@blackheaven
Copy link
Contributor Author

For some reasons, Bulk operation does not seems to perform correctly, not sure why, it has not changed since 2019.

If anyone can have a look at it...

@blackheaven
Copy link
Contributor Author

Much better!

@blackheaven
Copy link
Contributor Author

@TristanCacqueray nearly done, it fails with:

      Exception: Decoding of AddDocRequest {addDocRequestIndex = "test-macroscope", addDocRequestCrawler = "testy", addDocRequestApikey = "secret", addDocRequestEntity = Just (Entity {entityEntity = Just (EntityEntityProjectName "opendev/neutron")}), addDocRequestChanges = [Change {changeId = "", changeNumber = 42, changeChangeId = "", changeTitle = "", changeText = "", changeUrl = "", changeCommitCount = 1, changeAdditions = 2, changeDeletions = 0, changeChangedFilesCount = 1, changeChangedFiles = [], changeCommits = [], changeRepositoryPrefix = "", changeRepositoryFullname = "", changeRepositoryShortname = "", changeAuthor = Nothing, changeOptionalMergedBy = Nothing, changeBranch = "", changeTargetBranch = "", changeCreatedAt = Just (Timestamp {timestampSeconds = 1622455200, timestampNanos = 0}), changeOptionalMergedAt = Nothing, changeUpdatedAt = Just (Timestamp {timestampSeconds = 1622455200, timestampNanos = 0}), changeOptionalClosedAt = Nothing, changeState = Enumerated {enumerated = Right Change_ChangeStateOpen}, changeOptionalDuration = Nothing, changeMergeable = "", changeLabels = [], changeAssignees = [], changeApprovals = [], changeDraft = False, changeOptionalSelfMerged = Nothing, changeOptionalMergedCommitSha = Nothing}], addDocRequestEvents = [], addDocRequestProjects = [], addDocRequestTaskDatas = [], addDocRequestIssues = [], addDocRequestIssueEvents = [], addDocRequestErrors = [CrawlerError {crawlerErrorMessage = "decode", crawlerErrorBody = "[\"Oops\"]", crawlerErrorCreatedAt = Just (Timestamp {timestampSeconds = 1760814620, timestampNanos = 441434087})}]} failed with: "Error in $: Failed reading: not a valid json value at 'Somethingwentwrong'"
      CallStack (from HasCallStack):
        error, called at src/Relude/Debug.hs:296:11 in relude-1.2.2.0-1k14DcbZXw3HxDb5R7Nqys:Relude.Debug
        error, called at src/Monocle/Client.hs:118:17 in monocle-1.11.2-inplace:Monocle.Client

@blackheaven
Copy link
Contributor Author

@TristanCacqueray done!

@blackheaven blackheaven changed the title chore: upgrade to bloodhound 0.25.0.0 chore: upgrade to bloodhound 0.26.0.0 Oct 19, 2025
@blackheaven
Copy link
Contributor Author

Greeeen!

@TristanCacqueray
Copy link
Contributor

That's really good, thanks you @blackheaven ! We'll take it from here shortly!

@morucci
Copy link
Collaborator

morucci commented Nov 18, 2025

Thanks you for the bump !

@morucci morucci added the merge me Trigger the merge process label Nov 18, 2025
@TristanCacqueray
Copy link
Contributor

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Nov 18, 2025

queue

🛑 Configuration not compatible with a branch protection setting

Details

The branch protection setting Require branches to be up to date before merging is not compatible with draft PR checks. To keep this branch protection enabled, update your Mergify configuration to enable in-place checks: set merge_queue.max_parallel_checks: 1, set every queue rule batch_size: 1, and avoid two-step CI (make merge_conditions identical to queue_conditions). Otherwise, disable this branch protection.

@TristanCacqueray TristanCacqueray marked this pull request as draft November 18, 2025 11:15
@TristanCacqueray TristanCacqueray marked this pull request as ready for review November 18, 2025 11:15
@TristanCacqueray
Copy link
Contributor

https://github.com/Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Nov 18, 2025

queue

🛑 Configuration not compatible with a branch protection setting

Details

The branch protection setting Require branches to be up to date before merging is not compatible with draft PR checks. To keep this branch protection enabled, update your Mergify configuration to enable in-place checks: set merge_queue.max_parallel_checks: 1, set every queue rule batch_size: 1, and avoid two-step CI (make merge_conditions identical to queue_conditions). Otherwise, disable this branch protection.

@morucci morucci merged commit 7992ec0 into change-metrics:master Nov 18, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge me Trigger the merge process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants