Adjust CSS specificity to ensure Japanese font is properly applied - specify font family explicitly#2778
Conversation
🦋 Changeset detectedLatest commit: 19e37d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Walkthrough
Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🎯 2 (Simple) | ⏱️ ~8분 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (4)
Comment |
timok1m
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2778 +/- ##
=======================================
Coverage 81.80% 81.80%
=======================================
Files 149 149
Lines 2957 2957
Branches 934 934
=======================================
Hits 2419 2419
- Misses 504 534 +30
+ Partials 34 4 -30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Chromatic Report🚀 Congratulations! Your build was successful! |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @channel.io/bezier-react@3.6.2 ### Patch Changes - Adjust CSS specificity to ensure Japanese font is properly applied - specify font family explicitly ([#2778](#2778)) by @timok1m ## bezier-figma-plugin@0.7.21 ### Patch Changes - Updated dependencies - @channel.io/bezier-react@3.6.2 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **버그 수정** * 일본어 글꼴 렌더링을 위해 CSS 특이성을 명시적으로 설정하여 글꼴이 올바르게 표시되도록 개선했습니다. * **패키지 업데이트** * Bezier React 3.6.2 릴리스 * Bezier Figma Plugin 0.7.21 릴리스 <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…revert to 3.6.1 approach (#2780) <!-- How to write a good PR title: - Follow [the Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/). - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ## Self Checklist - [x] I wrote a PR title in **English** and added an appropriate **label** to the PR. - [x] I wrote the commit message in **English** and to follow [**the Conventional Commits specification**](https://www.conventionalcommits.org/en/v1.0.0/). - [x] I [added the **changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md) about the changes that needed to be released. (or didn't have to) - [x] I wrote or updated **documentation** related to the changes. (or didn't have to) - [x] I wrote or updated **tests** related to the changes. (or didn't have to) - [ ] I tested the changes in various browsers. (or didn't have to) - Windows: Chrome, Edge, (Optional) Firefox - macOS: Chrome, Edge, Safari, (Optional) Firefox ## Related Issue <!-- Please link to issue if one exists --> - #2778 - #2776 <!-- Fixes #0000 --> ## Summary <!-- Please brief explanation of the changes made --> css 적용 우선순위로 인해 일본어일 때 타이포그래피 폰트의 오버라이드가 적용되지 않는 문제를 재수정하여 최종 적용합니다. ## Details <!-- Please elaborate description of the changes --> - #2776 에서 적용했던 방식이 유효한 방법이었음을 확인했습니다. - 해당 방식이 동작하지 않았던 것은 베지어 패키지 외부(베지어를 사용하던 어플리케이션)의 문제였음을 확인했습니다. - 처음 적용했던 방식으로 다시 회귀하고, css 선택자를 보다 간결하게 유지하여 마무리합니다. ### Breaking change? (Yes/No) <!-- If Yes, please describe the impact and migration path for users --> No ## References <!-- Please list any other resources or points the reviewer should be aware of --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## 버그 수정 * 일본어 폰트 표시를 위한 CSS 특이성 조정 * 폰트 변수 체계 개선 (제목, 본문, 디스플레이 폰트 분리) * 코드 블록 폰트 변수 최적화 <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 participant
Self Checklist
Related Issue
Summary
css 적용 우선순위로 인해 일본어일 때 타이포그래피 폰트의 오버라이드가 적용되지 않는 문제를 재수정합니다.
Details
Breaking change? (Yes/No)
No
References
Summary by CodeRabbit
릴리스 노트
✏️ Tip: You can customize this high-level summary in your review settings.