This repository was archived by the owner on Sep 12, 2024. It is now read-only.
CG Demo: enabling/disabling certain functionality#556
Draft
ChartistDev wants to merge 41 commits intodevelopfrom
Draft
CG Demo: enabling/disabling certain functionality#556ChartistDev wants to merge 41 commits intodevelopfrom
ChartistDev wants to merge 41 commits intodevelopfrom
Conversation
✅ Deploy Preview for frontend-sb canceled.
|
manassolanki
changed the title
Added a 'before_request' hook to check if the destination endpoint is present in the whitelisted APIs. If yes allow the request to pass through, else return a message indicating the endpoint is unaccessable in demo version.
Fixed request context bug in register_hooks fucntion. Added REACT_APP_IS_DEMO environment variable in docker-compose.
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Generic High Entropy Secret | 9b7fe08 | .env | View secret |
| 2745890 | Generic High Entropy Secret | 1bc2609 | .env | View secret |
| 2745890 | Generic High Entropy Secret | c1baf44 | .env | View secret |
| 2745890 | Generic High Entropy Secret | e3c234c | .env | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Samyak2
reviewed
Mar 25, 2022
Contributor
Samyak2
left a comment
Samyak2
left a comment
There was a problem hiding this comment.
@bhargavsk1077 left some comments for the backend code.
Samyak2
reviewed
Mar 25, 2022
Member
|
@bhargavsk1077 @ChartistDev We can pick these changes tomorrow. Let's target to get this branch merged in the next few days. |
|
|
Disallowed:
- Edit config - anonymous reporting and alert report time
Allowed:
- Alerts dashboard
- Task monitor
- Listing endpoints:
- The checkboxes in the filter for KPI and alert screen were broken
because of this
Multi-level/nested was unnecessary and gave an error in debug mode: https://stackoverflow.com/questions/66190958/python-flask-framework-assertionerror-a-setup-function-was-called-after-the-fi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.