fix: correct memory limit detection for cgroup v1 and v2 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ajoy-zero The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- Fix memory limit detection logic for cgroup v1: treat 0x7FFFFFFFFFFFF000 (9223372036854771712) as unlimited. - Ensure cgroup v2 uses "max" as unlimited. - Update comments to English for better readability. - This ensures memory stress respects container memory limits correctly. Signed-off-by: xiejunqiao <[email protected]>
- Change exec.Command("memStress", ...) to exec.Command("./memStress", ...)
- This avoids "executable file not found in $PATH" error when current directory is not in $PATH
- No impact on other features
Signed-off-by: xiejunqiao <[email protected]>
|
@STRRL PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix memory limit detection logic for cgroupfs Close #8 Close #5
fix: use ./memStress in exec.Command to avoid PATH not found error Close #7
What's changed and how it works?
Related changes
chaos-meshTests
Note: A temporary --print-mem flag was added during development for testing purposes. It has been removed before finalizing the PR.
The situation where cgroup1 is restricted
There are no restrictions on cgroup1
(cgroup2) Docker container with a 32GB memory limit, result as follows (host has ~8GB physical memory):
(cgroup2) Docker container with a 10GB memory limit, result as follows (host has ~2GB physical memory):