-
Notifications
You must be signed in to change notification settings - Fork 963
Add .gitattributes to force LF line endings on shell scripts #3561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add .gitattributes to force LF line endings on shell scripts #3561
Conversation
|
Please make sure PRs, especially for issues that are popular, are linked to the issue they solve (either with a "fixes #XXX" in the description or by manually setting it in the sidebar like I just did - if you have access to that) It helps keep track of things when there are duplicate PRS for the same thing (and also tells people the issue has been claimed so they dont submit more duplicates |
|
will take care of this , from the next time, and will also mention in the PR description for the issue which it is raised for. |
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
3c66987 to
0db1888
Compare
|
rebased the recent chages from the main branch |
|
@guptapratykshh There are a couple of other PRs targeting the same issue (#35556, #3561). Could you all please discuss the best way forward and come up with just one PR and close the rest? You can discuss the optimal way forward in the linked issue #3545. |
266002f to
eb70536
Compare
I have removed my pull request as it targeted the same issue as of this PR , this PR gives a correct solution for LF line endings problem , and @guptapratykshh you can also consider adding .yaml in the attributes as i run a successful test after adding that. |
|
@guptapratykshh I have some more changes in my own PR as well, I want to push those changes here or request some changes as a coauthor as that will be good, I think and y'all review those if you think those are right or wrong, don't forget to ping that point, so give me the access to push or requesting changes in this branch as in your fork repo. I will push those changes as a coauthor thx... |
|
I don't think we need the extensive list of changes in #3556. @Sukuna0007Abhi Is there a reason to add so many file extensions? This is regarding a review comment on that PR: "do we need to specify every single file type like this given that we assume things are text files in the first line?" |
|
i agree. the main goal is to fix specific execution issues often caused by CRLF in python and shell scripts. using * text=auto handles majority of other files correctly without needing an exhaustive list, which makes file easier to maintain. we should probably hold off on adding full list of extensions , that is unnecessary so , i think this PR is ready for the review. this is the final changes required as i did |
Description
Add .gitattributes to force LF line endings on shell scripts
#3545.
Notes for Reviewers
Signed commits