Replace subprocess.call() with check_call() in db.py to prevent silent failures #3580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to prevent silent failures Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
shlokgilda
previously approved these changes
Jan 15, 2026
Collaborator
shlokgilda
left a comment
shlokgilda
left a comment
There was a problem hiding this comment.
LGTM. Love the short, targeted PR. Added one suggestion to fix a docstring that was incorrect even before this change.
augur/application/cli/db.py
Outdated
| @test_db_connection | ||
| def check_for_upgrade(): | ||
| """ | ||
| Upgrade the configured database to the latest version |
Collaborator
There was a problem hiding this comment.
Could you fix this docstring here as well: Show available database migration history
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
shlokgilda
approved these changes
Jan 16, 2026
sgoggins
added
API
Member
|
Waiting on Podman end to end test. The fundamental difference here is really the provision of detailed error messages in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I replaced subprocess.call with check_call in the database cli, ensuring that operations stop immediately and report errors if something goes wrong.
This PR fixes #3579
Notes for Reviewers
Signed commits