Skip to content

Skip converter test when network atomics are available#55

Merged
benharsh merged 1 commit intochapel-lang:mainfrom
benharsh:converter-skip
Feb 13, 2026
Merged

Skip converter test when network atomics are available#55
benharsh merged 1 commit intochapel-lang:mainfrom
benharsh:converter-skip

Conversation

@benharsh
Copy link
Member

The code path for network atomics happens to run into a bug in the converter, which causes the test to fail.

The code path for network atomics happens to run into a bug in the
converter, which causes the test to fail.
@benharsh benharsh requested a review from bradcray February 13, 2026 17:54
@benharsh
Copy link
Member Author

I was able to reproduce the initial bug on my laptop, and fixed it, assuming that would be the end of this. Alas, there's another bug related to network atomics, so instead of putting more time into this I'm inclined to just skip the test.

Copy link
Member

@bradcray bradcray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works for me, thanks! The other fix you mentioned is the one you already merged, is that right? (which resolved this test in other configs?)

The only thing that nags at me a little bit here is what made this only start failing on the 19th. All the PRs that went in on the 18th look pretty innocuous. But I don't think that's probably worth pursuing unless it makes the cause and fix obvious.

In any case, I don't mind skipping it in this config given how "advanced" it is and the converter's focus so far.

@benharsh
Copy link
Member Author

I merged chapel-lang/chapel#28390 a couple of days ago, which fixed the original error message we were seeing. I somewhat foolishly only tested this on my mac, and so I didn't see the failure related to network atomics that we now see in nightly testing.

@benharsh benharsh merged commit e1ff434 into chapel-lang:main Feb 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants