Adjust sidenotes to not rely on border width subtraction#58
Merged
DanilaFe merged 1 commit intochapel-lang:mainfrom Feb 24, 2026
Merged
Adjust sidenotes to not rely on border width subtraction#58DanilaFe merged 1 commit intochapel-lang:mainfrom
DanilaFe merged 1 commit intochapel-lang:mainfrom
Conversation
Signed-off-by: Danila Fedorin <daniel.fedorin@hpe.com>
benharsh
approved these changes
Feb 23, 2026
Member
|
This change looks good to me in action, and I verified that the sidenotes that caused me to open the original issue don't change their linefeeds under this branch. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26.
As I outlined in the issue:
This PR does this.
I think it looks pretty nice:
Reviewed by @benharsh -- thanks!
Testing