Fix external URLs in sidenotes#59
Merged
DanilaFe merged 1 commit intochapel-lang:mainfrom Feb 24, 2026
Merged
Conversation
Signed-off-by: Danila Fedorin <daniel.fedorin@hpe.com>
jabraham17
approved these changes
Feb 23, 2026
bradcray
added a commit
that referenced
this pull request
Feb 25, 2026
Some of these were enabled by #59; others may have just been oversights in writing up the articles. --- Signed-off-by: Brad Chamberlain <bradcray@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16.
The author of the template was a little overzealous with using the space-erasing
-}}in templates. Even though there was a space betweenhref="..."andrel="...", the space-erasing template gobbled it up, leading to HTML likea href=""rel="". The lack of spaces seems to confuse some part of the rendering pipeline. Note sure why this wasn't a broader issue, but it's good to fix the problem anyway. I've replaced sidenote links with markdown links in the article listed in Brad's issue, and still renders fine.Reviewed by @jabraham17 -- thanks!