28099 feat unittest assertclose#28144

Open

jmag722 wants to merge 15 commits intochapel-lang:mainfrom

jmag722:28099-feat-unittest-assertclose

Commits on Jan 30, 2026

WIP JMM[#28099]: Rough draft of assertClose for scalar and array types, using overloaded proc. Attempted simple test. UnitTests (AssertClose, AssertEquals, AssertTrue) failing with:
jmag722
committed
WIP JMM[#28099]: assertClose still not working, still same error, but getting rid of invalid where clause (ruling that out), adding void return type
jmag722
committed
WIP JMM[#28099]: assertClose working with array and floating point! making params param proc fixed issue. relax exact domain matching in the future
jmag722
committed
WIP JMM[28099]: simplified error message, arrays must be same shape but different indexing allowed,add additional tests. withinTol made generic. fixed printing for complex numbers
jmag722
committed
Update assertClose and withinTol documentation. add asserts to withinTol to check signs of tolerances
jmag722
committed
add tests to check signs of tolerances. withinTol now throws and add pragma
jmag722
committed
[#28099]: using more appropriate error types
jmag722
committed
Nan equality checks work for scalar comparisons
jmag722
committed
assert nan array elements are equal, add tests
jmag722
committed
add compareNan documentation, where clause
jmag722
committed
add default args to testAssert, use named arguments for clearer tests
jmag722
committed
assertClose now compares partial complex NaN consistently, updated test logic to reflect this
jmag722
committed
reorganize tests: passing first, fail last. added 2D array test, more thorough testing, remove redundant tests, give unique names to error messages for help parsing the good file
jmag722
committed
remove compareNanTrue with array inputs, b/c procedure with scalar arguments will automatically be promoted. improve comments, formatting
jmag722
committed
removing separate if block for complex arrays, compareComplex is promotable for arrays
jmag722
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

28099 feat unittest assertclose#28144

28099 feat unittest assertclose#28144
jmag722 wants to merge 15 commits intochapel-lang:mainfrom
jmag722:28099-feat-unittest-assertclose

Commits on Jan 30, 2026

WIP JMM[#28099]: Rough draft of assertClose for scalar and array types, using overloaded proc. Attempted simple test. UnitTests (AssertClose, AssertEquals, AssertTrue) failing with:

WIP JMM[#28099]: assertClose still not working, still same error, but getting rid of invalid where clause (ruling that out), adding void return type

WIP JMM[#28099]: assertClose working with array and floating point! making params param proc fixed issue. relax exact domain matching in the future

WIP JMM[28099]: simplified error message, arrays must be same shape but different indexing allowed,add additional tests. withinTol made generic. fixed printing for complex numbers

Update assertClose and withinTol documentation. add asserts to withinTol to check signs of tolerances

add tests to check signs of tolerances. withinTol now throws and add pragma

[#28099]: using more appropriate error types

Nan equality checks work for scalar comparisons

assert nan array elements are equal, add tests

add compareNan documentation, where clause

add default args to testAssert, use named arguments for clearer tests

assertClose now compares partial complex NaN consistently, updated test logic to reflect this

reorganize tests: passing first, fail last. added 2D array test, more thorough testing, remove redundant tests, give unique names to error messages for help parsing the good file

remove compareNanTrue with array inputs, b/c procedure with scalar arguments will automatically be promoted. improve comments, formatting

removing separate if block for complex arrays, compareComplex is promotable for arrays