Draft
Conversation
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
e-kayrakli
approved these changes
Dec 17, 2025
| MIN_ROCM6_REQ_VERSION = "6.0" | ||
| MAX_ROCM6_REQ_VERSION = "6.3" # upper bound non-inclusive | ||
| MAX_ROCM6_REQ_VERSION_NICE = "6.2.x" | ||
| MAX_ROCM6_REQ_VERSION = "6.4" # upper bound non-inclusive |
Contributor
There was a problem hiding this comment.
Semi serious question: Should we drop upper bounds here and let people try whatever version they might want to? Looking at the diff here, the only real "fix" here is this bump it looks like. Are we unnecessarily creating work for us to bump this up for each ROCm version?
Member
Author
There was a problem hiding this comment.
I would not be that opposed to removing the upper bound. I think it is a nicer user experience that users can only use Chapel with known-to-work versions, rather than getting build/runtime errors. However, its a maintenance burden and can also frustrate users.
Maybe a good compromise is to turn it into a warning?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for using Chapel with ROCm 6.3.
This PR does not resolve the issue with halting described in #26934, rather it just assumes it to be an acceptable error message.
TODO
start_test test/gpu/nativewithCHPL_GPU=amdstart_test test/gpu/nativewithCHPL_GPU=amdandCHPL_COMM=ofiResolves #26934
[Reviewed by @]