Fix ignored failures in Homebrew tests #28353
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arifthpe
force-pushed
the
homebrew-error-on-failure
branch
2 times, most recently
from
e5c645f to
5de0836
Compare
arifthpe
force-pushed
the
homebrew-error-on-failure
branch
from
972e280 to
72ab4dd
Compare
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
… download output Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
arifthpe
force-pushed
the
homebrew-error-on-failure
branch
from
2d078ab to
b5c5766
Compare
Signed-off-by: Anna Rift <[email protected]>
arifthpe
force-pushed
the
homebrew-error-on-failure
branch
from
b5c5766 to
98b2087
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around Homebrew/homebrew-test-bot#791 by inserting fake bottle info into the tested Homebrew Formula, so install errors are not ignored.
This issue was observed in the containerized Linuxbrew testing and not yet noticed on Mac, but I assume it applies to both and have applied the fix to both.
[reviewer info placeholder]
Testing: