fix(next): fix wrong iFrame preview URL on "Latest version" tab for translations (#500)#501
Merged
bojanbogdanovic merged 2 commits intochapter-three:mainfrom Dec 18, 2025
Conversation
|
Someone is attempting to deploy a commit to the Chapter Three Team on Vercel. A member of the Team first needs to authorize it. |
…ion" tab for translations.
Loading a revision now relies on the language parameters provided by route_match, ensuring the correct translated revision is returned instead of always falling back to the default language.
bojanbogdanovic
force-pushed
the
fix/issue-500-wrong-preview-url-when-translation-latest-version
branch
from
9a8782d to
d557675
Compare
bojanbogdanovic
approved these changes
Dec 18, 2025
bojanbogdanovic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #500
The previous method
EntityStorage::loadRevision()loses specific language information. SomegetTranslation($langcode)should be added, but its not really needed as$route_match->getParameter('node')already contains the correct revision and langcode information.