fix(next): next_entity_type_config dependencies #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mglaman is attempting to deploy a commit to the Chapter Three Team on Vercel. A member of the Team first needs to authorize it. |
JohnAlbin
reviewed
Feb 22, 2024
modules/next/tests/src/Kernel/Entity/NextEntityTypeConfigTest.php
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@JohnAlbin I tried running locally, but for some reason all tests fail now. So I wanted to use the CI... but it looks like EDIT: needed to update |
Contributor
Author
|
Okay, it should be all set, now |
bojanbogdanovic
force-pushed
the
NextEntityTypeConfig-config-dependencies
branch
from
40e285e to
99722b5
Compare
Fixes dependencies in next_entity_type_config for the entity type and bundle being targeted.
save test entity so dependencies are calculated
bojanbogdanovic
force-pushed
the
NextEntityTypeConfig-config-dependencies
branch
from
99722b5 to
747b56d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #599 #282, dependencies in next_entity_type_config for the entity type and bundle being targeted.
This pull request is for: (mark with an "x")
examples/*modules/nextpackages/next-drupalstarters/basic-starterstarters/graphql-starterGitHub Issue: #599
Code changes need test coverage. If you don't know
how to make tests, check this box to ask for help.
Describe your changes
Adds configuration dependency to target entity type and bundle