feat(next-drupal, starters-*) - Add Next 15 support #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
|
@yobottehg is attempting to deploy a commit to the Chapter Three Team on Vercel. A member of the Team first needs to authorize it. |
backlineint
suggested changes
Jan 17, 2025
Contributor
backlineint
left a comment
backlineint
left a comment
There was a problem hiding this comment.
Thanks for the contribution @yobottehg! Provided some inline feedback, but this is most of the way there from my perspective.
backlineint
suggested changes
Jan 23, 2025
Contributor
backlineint
left a comment
backlineint
left a comment
There was a problem hiding this comment.
Just about there! From my perspective this just needs to go back to using the custom link component (see comments inline) and also needs to have a merge conflict resolved, and then it is good to go.
robdecker
requested changes
Jan 23, 2025
Contributor
Author
|
All requested changes addressed |
# Conflicts: # yarn.lock
backlineint
approved these changes
Jan 27, 2025
Contributor
backlineint
left a comment
backlineint
left a comment
There was a problem hiding this comment.
Thanks for all the work on this @yobottehg !
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for: (mark with an "x")
examples/*modules/nextpackages/next-drupalstarters/basic-starterstarters/graphql-starterstarters/pages-starterGitHub Issue: #811
Describe your changes
After reading through https://nextjs.org/docs/app/building-your-application/upgrading/version-15#async-request-apis-breaking-change I decided to not add the "workaround" to also support Next.js 14 because:
The Changes for<Link>inside the Pages router starter is because the types did not work anymore with the pages router and react 19. I could not find a workaround. Therefore I just removed the custom "non-prefetch" link as I think this an implementation detail which is not required inside a starter / example.