feat: Add Support for App Router Invalidation by Tag in Drupal Module (#812) #827
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
|
I was able to confirm that the tags are correctly passed to the frontend.
|
| $tags[] = $entity->getEntityTypeId() . '_list'; | ||
| $tags[] = $entity->getEntityTypeId() . '_list:' . $entity->bundle(); | ||
| } | ||
| $cache_tags = implode(',', $entity->getCacheTags()); |
There was a problem hiding this comment.
@minnur I think the entity list tags we still have to add manually, at least in my test for nodes for example $entity->getCacheTags only gave node:8
There was a problem hiding this comment.
I didn't know about this, but apparently if we do this:
$entity->getEntityType()->getListCacheTags();We should get the correct list tag. The one with the bundle at the end we still need to create manually.
There was a problem hiding this comment.
Good find! I added that to the plugin. See db2690b
I noticed $entity->getEntityType()->getListCacheTags(); does not have entity_type_list:bundle. So I looked at \Drupal\Entity\EntityBase class and found a method getListCacheTagsToInvalidate() that adds that to the invalidation list and implemented the same logic in the plugin.
| $list_tags = $entity->getEntityType()->getListCacheTags(); | ||
| if ($entity->getEntityType()->hasKey('bundle')) { | ||
| $list_tags[] = $entity->getEntityTypeId() . '_list:' . $entity->bundle(); | ||
| } | ||
| $combined_tags = array_merge($entity->getCacheTags(), $list_tags); | ||
| $cache_tags = implode(',', $combined_tags); |
There was a problem hiding this comment.
This looks great. It is much more concise than our original version.
…
This pull request is for: (mark with an "x")
examples/*modules/nextpackages/next-drupalstarters/basic-starterstarters/graphql-starterstarters/pages-starterGitHub Issue: #812
Describe your changes
Added new cache tag revalidator plugin to the next module.