fix(next): make EntityResource constructor compatible with Drupal 10/11#882
Merged
bojanbogdanovic merged 2 commits intochapter-three:mainfrom Dec 24, 2025
Conversation
|
@bojanbogdanovic is attempting to deploy a commit to the Chapter Three Team on Vercel. A member of the Team first needs to authorize it. |
7 tasks
robdecker
requested changes
Dec 17, 2025
8295a51 to
8e4b16a
Compare
bojanbogdanovic
added a commit
that referenced
this pull request
Dec 26, 2025
Replaced constructor injection with a setter method to reduce the risk of BC breaks from the parent class. Removed the redundant service definition from services.yml, relying solely on the ServiceProvider for service configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #877
This pull request is for:
modules/nextGitHub Issue: #877
Description:
This PR updates EntityResource to work across Drupal 10 and 11 by refactoring the constructor to handle variable parent arguments and inject
$maxSizeas a parameter.Background / Difference between D10 and D11: