Use device detector to filter bots#277
Open
tacataca wants to merge 6 commits intocharlotte-ruby:masterfrom
Open
Use device detector to filter bots#277tacataca wants to merge 6 commits intocharlotte-ruby:masterfrom
tacataca wants to merge 6 commits intocharlotte-ruby:masterfrom
Conversation
Use the device detector gem to identify bots as they have a much better maintained list. Straightforward swap.
- Add a second test for wild card matching. - A-Online Search doesn't appear on the latest bot user agent lists, so changing with another example.
Remove nokogiri dependency and update task to use list from device_detector
|
Hi @johnmcaliley, Can you or other contributors review this PR? Thanks! |
Contributor
|
@tacataca You should resolve conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the bot filtering system to use the device detector gem.
Very straightforward swap to use a much better maintained list, however introduces an external dependancy. Also updates the rake task.
Took the liberty to also fix some issues with the CI.