Hyperlinks on user profile Issue #39#67
Open
montethinks wants to merge 4 commits intocharlottedevs:masterfrom
Open
Hyperlinks on user profile Issue #39#67montethinks wants to merge 4 commits intocharlottedevs:masterfrom
montethinks wants to merge 4 commits intocharlottedevs:masterfrom
Conversation
binarymason
reviewed
Jun 27, 2017
| <p >Twitter: <a href={account.twitter_handle}>{account.twitter_handle}</a></p> | ||
| <p >StackOverflow: <a href={account.stackoverflow_url}>{account.stackoverflow_url | ||
| .substring( | ||
| account.stackoverflow_url.lastIndexOf('/') + 1, |
Member
There was a problem hiding this comment.
@montethinks why is the lastIndexOf('/') necessary here instead of just account.stackoverflow_url?
Author
There was a problem hiding this comment.
Hey @binarymason I added that to trim the username from the url so that the link displays as the stackoverflow username similar to the Twitter and Github links instead of https://stackoverflow.com/users/<id>/<user_name>. I can change it and resubmit if it's not inline with what you had in mind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the hyperlinks on the user profile page to resolve to the appropriate site i.e.
https://twitter.com/<handle>. The Stack Overflow link resolves to the user's profile page but only the username is displayed.