Skip to content

feat: add an optional modtime section to the filepicker #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loicalbertin wants to merge 3 commits into
base: v2-exp
Choose a base branch
from
+14 −0
Open

feat: add an optional modtime section to the filepicker #807

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69c7483
feat: add an optional modtime section to the filepicker
loicalbertin May 21, 2025
05db53a
Merge branch 'v2-exp' into feature/GH-780-modtime-on-filepicker
loicalbertin Jun 30, 2025
d8cd441
Update filepicker/filepicker.go
loicalbertin Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions filepicker/filepicker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ import (
"github.com/dustin/go-humanize"
)

// DefaultModTimeLayout is the default layout used to format modification time for a given file.
const DefaultModTimeLayout = "Jan _2 15:04"
Copy link
Member

@meowgorithm meowgorithm Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason to export this?

Copy link
Author

@loicalbertin loicalbertin Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No particular reason expect to have it easily accessible in the documentation.

We could make it private if you prefer.

Copy link
Member

@meowgorithm meowgorithm Aug 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, well that's good enough reason to keep it public.


var lastID int64

func nextID() int {
Expand All @@ -34,6 +37,7 @@ func New() Model {
ShowPermissions: true,
ShowSize: true,
ShowHidden: false,
ModTimeLayout: DefaultModTimeLayout,
DirAllowed: false,
FileAllowed: true,
AutoHeight: true,
Expand Down Expand Up @@ -103,6 +107,7 @@ type Styles struct {
Selected lipgloss.Style
DisabledSelected lipgloss.Style
FileSize lipgloss.Style
ModTime lipgloss.Style
EmptyDirectory lipgloss.Style
}

Expand All @@ -119,6 +124,7 @@ func DefaultStyles() Styles {
Permission: lipgloss.NewStyle().Foreground(lipgloss.Color("244")),
Selected: lipgloss.NewStyle().Foreground(lipgloss.Color("212")).Bold(true),
FileSize: lipgloss.NewStyle().Foreground(lipgloss.Color("240")).Width(fileSizeWidth).Align(lipgloss.Right),
ModTime: lipgloss.NewStyle().Foreground(lipgloss.Color("240")),
EmptyDirectory: lipgloss.NewStyle().Foreground(lipgloss.Color("240")).PaddingLeft(paddingLeft).SetString("Bummer. No Files Found."),
}
}
Expand All @@ -141,6 +147,8 @@ type Model struct {
files []os.DirEntry
ShowPermissions bool
ShowSize bool
ShowModTime bool
ModTimeLayout string
ShowHidden bool
DirAllowed bool
FileAllowed bool
Expand Down Expand Up @@ -396,6 +404,9 @@ func (m Model) View() string {
if m.ShowSize {
selected += fmt.Sprintf("%"+strconv.Itoa(m.Styles.FileSize.GetWidth())+"s", size)
}
if m.ShowModTime {
selected += " " + info.ModTime().Format(m.ModTimeLayout)
}
selected += " " + name
if isSymlink {
selected += " → " + symlinkPath
Expand Down Expand Up @@ -429,6 +440,9 @@ func (m Model) View() string {
if m.ShowSize {
s.WriteString(m.Styles.FileSize.Render(size))
}
if m.ShowModTime {
s.WriteString(" " + m.Styles.ModTime.Render(info.ModTime().Format(m.ModTimeLayout)))
}
s.WriteString(" " + fileName)
s.WriteRune('\n')
}
Expand Down