Skip to content

feat: disable pty emulation #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: disable pty emulation #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,13 @@ type Session interface {
// the request handling loop. Registering nil will unregister the channel.
// During the time that no channel is registered, breaks are ignored.
Break(c chan<- bool)

// DisablePtyEmulation disables the session from emulating a pty when a pty
// is requested. If you're allocating a pty for the session, you should
// call this method to disable the pty emulation before any call to Write.
// This affects the behavior of Stderr() and Write and stops them from
// translating NL -> CRNL (`\n` -> `\r\n`).
DisablePtyEmulation()
}

// maxSigBufSize is how many signals will be buffered
Expand Down Expand Up @@ -125,17 +132,22 @@ type session struct {
sigCh chan<- Signal
sigBuf []Signal
breakCh chan<- bool
disablePtyEmu bool
}

func (sess *session) DisablePtyEmulation() {
sess.disablePtyEmu = true
}

func (sess *session) Stderr() io.ReadWriter {
if sess.pty != nil {
if sess.pty != nil && !sess.disablePtyEmu {
return NewPtyReadWriter(sess.Channel.Stderr())
}
return sess.Channel.Stderr()
}

func (sess *session) Write(p []byte) (int, error) {
if sess.pty != nil {
if sess.pty != nil && !sess.disablePtyEmu {
return NewPtyWriter(sess.Channel).Write(p)
}
return sess.Channel.Write(p)
Expand Down