Skip to content

Conversation

@stonedragon
Copy link

No description provided.

@rgevaert
Copy link

rgevaert commented Jun 8, 2018

If we get the tests running, would it still be merged?

@rgevaert
Copy link

@butlern please give a comment. Thanks! I'm currently using it from the fork...

@butlern
Copy link
Contributor

butlern commented Jun 13, 2018

yep, for sure. One note though and this might impact tests. I recently pushed changes to master which remove support for puppet3, vastly simplifying the test matrix. So the tests might just pass w/out any code changes if you rebase. However, if you need puppet3, that will be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants