Skip to content

Fix min js two renames #11470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 10, 2025
Merged

Fix min js two renames #11470

merged 3 commits into from
Jun 10, 2025

Conversation

fulldecent
Copy link
Contributor

This is alternative that incorporates #11457

@fulldecent fulldecent mentioned this pull request Aug 28, 2023
Open
LeeLenaleee
LeeLenaleee previously approved these changes Aug 28, 2023
View reviewed changes
@LeeLenaleee LeeLenaleee added this to the Version 4.5.0 milestone Aug 28, 2023
@fulldecent fulldecent force-pushed the fix-min-js-two-renames branch from 5b825a9 to 699753f Compare September 6, 2023 23:00
@etimberg
Copy link
Member

etimberg commented Sep 7, 2023

@fulldecent I think the test failures might be real. It looks like it fails to import https://github.com/chartjs/Chart.js/blob/master/test/BasicChartWebWorker.js#L9

@etimberg etimberg removed this from the Version 4.4.2 milestone Feb 28, 2024
@fulldecent
Copy link
Contributor Author

@etimberg requesting review please

1 similar comment
@fulldecent
Copy link
Contributor Author

@etimberg requesting review please

etimberg
etimberg previously approved these changes Jun 5, 2025
View reviewed changes
@etimberg
Copy link
Member

etimberg commented Jun 5, 2025

Sorry @fulldecent, was off on pat-leave for a while and didn't check github too closely.

@LeeLenaleee ok if I merge this?

@LeeLenaleee
Copy link
Collaborator

The tests keep failing, also locally but so far I have not been able to figure out why this happens since the file does show up in the dist folder.

I am not sure if we should merge it because I doubt that the failing test will disappear.

@fulldecent fulldecent dismissed stale reviews from etimberg and LeeLenaleee via d0baac7 June 10, 2025 01:07
@fulldecent
Copy link
Contributor Author

fulldecent commented Jun 10, 2025 •
edited
Loading

@LeeLenaleee I have no idea what I'm doing. And nobody else is using Karma exactly how we do it.

But somehow I got the build to pass.

@etimberg etimberg merged commit debdf07 into chartjs:master Jun 10, 2025
7 checks passed
DawoudIO added a commit to ChurchCRM/CRM that referenced this pull request Aug 31, 2025
@DawoudIO
[Snyk] Upgrade chart.js from 4.4.9 to 4.5.0 (#7346)
8e1bb65 
![snyk-top-banner](https://res.cloudinary.com/snyk/image/upload/r-d/scm-platform/snyk-pull-requests/pr-banner-default.svg)


<h3>Snyk has created this PR to upgrade chart.js from 4.4.9 to
4.5.0.</h3>

:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.

<hr/>


- The recommended version is **1 version** ahead of your current
version.

- The recommended version was released **a month ago**.



<details>
<summary><b>Release notes</b></summary>
<br/>
  <details>
    <summary>Package name: <b>chart.js</b></summary>
    <ul>
      <li>
<b>4.5.0</b> - <a
href="https://redirect.github.com/chartjs/Chart.js/releases/tag/v4.5.0">2025-06-14</a></br><h1>Essential
Links</h1>
<ul>
<li><a href="https://www.npmjs.com/package/chart.js"
rel="nofollow">npm</a></li>
<li><a
href="https://www.chartjs.org/docs/4.5.0/migration/v4-migration.html"
rel="nofollow">Migration guide</a></li>
<li><a href="https://www.chartjs.org/docs/4.5.0/"
rel="nofollow">Docs</a></li>
<li><a href="https://www.chartjs.org/docs/4.5.0/api/"
rel="nofollow">API</a></li>
<li><a
href="https://www.chartjs.org/docs/4.5.0/samples/information.html"
rel="nofollow">Samples</a></li>
</ul>
<h2>Enhancements</h2>
<ul>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1870361497" data-permission-text="Title is private"
data-url="chartjs/Chart.js#11470"
data-hovercard-type="pull_request"
data-hovercard-url="/chartjs/Chart.js/pull/11470/hovercard"
href="https://redirect.github.com/chartjs/Chart.js/pull/11470">#11470</a>
Fix min js two renames</li>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="2966641895" data-permission-text="Title is private"
data-url="chartjs/Chart.js#12054"
data-hovercard-type="pull_request"
data-hovercard-url="/chartjs/Chart.js/pull/12054/hovercard"
href="https://redirect.github.com/chartjs/Chart.js/pull/12054">#12054</a>
[fix] #12048 - Add selfJoin option for doughnut graphs</li>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="2992511358" data-permission-text="Title is private"
data-url="chartjs/Chart.js#12058"
data-hovercard-type="pull_request"
data-hovercard-url="/chartjs/Chart.js/pull/12058/hovercard"
href="https://redirect.github.com/chartjs/Chart.js/pull/12058">#12058</a>
feature: make above/below colors in filler plugin work with pivoted line
charts</li>
</ul>
<h2>Bugs Fixed</h2>
<ul>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3045985317" data-permission-text="Title is private"
data-url="chartjs/Chart.js#12070"
data-hovercard-type="pull_request"
data-hovercard-url="/chartjs/Chart.js/pull/12070/hovercard"
href="https://redirect.github.com/chartjs/Chart.js/pull/12070">#12070</a>
Fix: display stacked bar with multiple x-Axis</li>
</ul>
<h2>Types</h2>
<ul>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3000100733" data-permission-text="Title is private"
data-url="chartjs/Chart.js#12064"
data-hovercard-type="pull_request"
data-hovercard-url="/chartjs/Chart.js/pull/12064/hovercard"
href="https://redirect.github.com/chartjs/Chart.js/pull/12064">#12064</a>
Document requirement of 'this' when calling tick formatters</li>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="2997699156" data-permission-text="Title is private"
data-url="chartjs/Chart.js#12063"
data-hovercard-type="pull_request"
data-hovercard-url="/chartjs/Chart.js/pull/12063/hovercard"
href="https://redirect.github.com/chartjs/Chart.js/pull/12063">#12063</a>
Add type definition for beforeEvent changed</li>
</ul>
<h2>Documentation</h2>
<ul>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3137696049" data-permission-text="Title is private"
data-url="chartjs/Chart.js#12088"
data-hovercard-type="pull_request"
data-hovercard-url="/chartjs/Chart.js/pull/12088/hovercard"
href="https://redirect.github.com/chartjs/Chart.js/pull/12088">#12088</a>
Fix grammar typo: 'only draw line' -&gt; 'only draw lines'</li>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3135889497" data-permission-text="Title is private"
data-url="chartjs/Chart.js#12087"
data-hovercard-type="pull_request"
data-hovercard-url="/chartjs/Chart.js/pull/12087/hovercard"
href="https://redirect.github.com/chartjs/Chart.js/pull/12087">#12087</a>
Fix minified URL for development builds in the docs</li>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3127790559" data-permission-text="Title is private"
data-url="chartjs/Chart.js#12084"
data-hovercard-type="pull_request"
data-hovercard-url="/chartjs/Chart.js/pull/12084/hovercard"
href="https://redirect.github.com/chartjs/Chart.js/pull/12084">#12084</a>
fix: correct grammar in segment comments (an segment -&gt; a
segment)</li>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3107078825" data-permission-text="Title is private"
data-url="chartjs/Chart.js#12082"
data-hovercard-type="pull_request"
data-hovercard-url="/chartjs/Chart.js/pull/12082/hovercard"
href="https://redirect.github.com/chartjs/Chart.js/pull/12082">#12082</a>
Update docs for Developers API</li>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3018509008" data-permission-text="Title is private"
data-url="chartjs/Chart.js#12068"
data-hovercard-type="pull_request"
data-hovercard-url="/chartjs/Chart.js/pull/12068/hovercard"
href="https://redirect.github.com/chartjs/Chart.js/pull/12068">#12068</a>
Fix minor typo, missing period</li>
</ul>
<h2>Development</h2>
<ul>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3146667294" data-permission-text="Title is private"
data-url="chartjs/Chart.js#12090"
data-hovercard-type="pull_request"
data-hovercard-url="/chartjs/Chart.js/pull/12090/hovercard"
href="https://redirect.github.com/chartjs/Chart.js/pull/12090">#12090</a>
bump version to 4.5.0</li>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="2841166263" data-permission-text="Title is private"
data-url="chartjs/Chart.js#12025"
data-hovercard-type="pull_request"
data-hovercard-url="/chartjs/Chart.js/pull/12025/hovercard"
href="https://redirect.github.com/chartjs/Chart.js/pull/12025">#12025</a>
Bump pnpm/action-setup from 4.0.0 to 4.1.0</li>
</ul>
<p>Thanks to <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/FabTechAT/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/FabTechAT">@ FabTechAT</a>, <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/Jee-on/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/Jee-on">@ Jee-on</a>, <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/LeeLenaleee/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/LeeLenaleee">@ LeeLenaleee</a>, <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/R2Jeu-prive/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/R2Jeu-prive">@ R2Jeu-prive</a>, <a
class="user-mention notranslate" data-hovercard-type="organization"
data-hovercard-url="/orgs/dependabot/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/dependabot">@ dependabot</a>[bot], <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ffdm/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/ffdm">@ ffdm</a>, <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/fulldecent/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/fulldecent">@ fulldecent</a>, <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/joshkel/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/joshkel">@ joshkel</a>, <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/lucasleung8/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/lucasleung8">@ lucasleung8</a>, <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/nakanoh/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/nakanoh">@ nakanoh</a>, <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/xavierleune/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/xavierleune">@ xavierleune</a> and <a
href="https://redirect.github.com/apps/dependabot">dependabot[bot]</a></p>
      </li>
      <li>
<b>4.4.9</b> - <a
href="https://redirect.github.com/chartjs/Chart.js/releases/tag/v4.4.9">2025-04-15</a></br><h1>Essential
Links</h1>
<ul>
<li><a href="https://www.npmjs.com/package/chart.js"
rel="nofollow">npm</a></li>
<li><a
href="https://www.chartjs.org/docs/4.4.9/migration/v4-migration.html"
rel="nofollow">Migration guide</a></li>
<li><a href="https://www.chartjs.org/docs/4.4.9/"
rel="nofollow">Docs</a></li>
<li><a href="https://www.chartjs.org/docs/4.4.9/api/"
rel="nofollow">API</a></li>
<li><a
href="https://www.chartjs.org/docs/4.4.9/samples/information.html"
rel="nofollow">Samples</a></li>
</ul>
<ul>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="2870946621" data-permission-text="Title is private"
data-url="chartjs/Chart.js#12037"
data-hovercard-type="pull_request"
data-hovercard-url="/chartjs/Chart.js/pull/12037/hovercard"
href="https://redirect.github.com/chartjs/Chart.js/pull/12037">#12037</a>
Update docs</li>
</ul>
<h2>Bugs Fixed</h2>
<ul>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="2990870549" data-permission-text="Title is private"
data-url="chartjs/Chart.js#12057"
data-hovercard-type="pull_request"
data-hovercard-url="/chartjs/Chart.js/pull/12057/hovercard"
href="https://redirect.github.com/chartjs/Chart.js/pull/12057">#12057</a>
fix: respect dataset clipping area when filling line charts</li>
</ul>
<h2>Documentation</h2>
<ul>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="2878759649" data-permission-text="Title is private"
data-url="chartjs/Chart.js#12039"
data-hovercard-type="pull_request"
data-hovercard-url="/chartjs/Chart.js/pull/12039/hovercard"
href="https://redirect.github.com/chartjs/Chart.js/pull/12039">#12039</a>
Add docs on using from Node.js</li>
</ul>
<h2>Development</h2>
<ul>
<li><a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="2996393290" data-permission-text="Title is private"
data-url="chartjs/Chart.js#12062"
data-hovercard-type="pull_request"
data-hovercard-url="/chartjs/Chart.js/pull/12062/hovercard"
href="https://redirect.github.com/chartjs/Chart.js/pull/12062">#12062</a>
Bump version to 4.4.9</li>
</ul>
<p>Thanks to <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/LeeLenaleee/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/LeeLenaleee">@ LeeLenaleee</a>, <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/adrianbrs/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/adrianbrs">@ adrianbrs</a> and <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/joshkel/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/joshkel">@ joshkel</a></p>
      </li>
    </ul>
from <a
href="https://redirect.github.com/chartjs/Chart.js/releases">chart.js
GitHub release notes</a>
  </details>
</details>

---

> [!IMPORTANT]
>
> - Check the changes in this PR to ensure they won't cause issues with
your project.
> - This PR was automatically created by Snyk using the credentials of a
real user.

---

**Note:** _You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs._

**For more information:** <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIyMWM4YzRjYy01Y2I1LTQyZWUtYmVkMS04YjRhYjM0OTg2ZjgiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjIxYzhjNGNjLTVjYjUtNDJlZS1iZWQxLThiNGFiMzQ5ODZmOCJ9fQ=="
width="0" height="0"/>

> - 🧐 [View latest project
report](https://app.snyk.io/org/dawoudio/project/e27b08aa-e5d2-4b10-8303-630a69d0b669?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 📜 [Customise PR
templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates?utm_source=&utm_content=fix-pr-template)
> - 🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/dawoudio/project/e27b08aa-e5d2-4b10-8303-630a69d0b669/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/dawoudio/project/e27b08aa-e5d2-4b10-8303-630a69d0b669/settings/integration?pkg&#x3D;chart.js&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)

[//]: #
'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"chart.js","from":"4.4.9","to":"4.5.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"21c8c4cc-5cb5-42ee-bed1-8b4ab34986f8","prPublicId":"21c8c4cc-5cb5-42ee-bed1-8b4ab34986f8","packageManager":"npm","priorityScoreList":[],"projectPublicId":"e27b08aa-e5d2-4b10-8303-630a69d0b669","projectUrl":"https://app.snyk.io/org/dawoudio/project/e27b08aa-e5d2-4b10-8303-630a69d0b669?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2025-06-14T20:42:08.165Z"},"vulns":[]}'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fulldecent @etimberg @LeeLenaleee