Add a function for getting zoom range #780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update types for getInitialScaleBounds - its implementation shows that it may return undefined.
Contributor
|
This is merged into my fork at https://github.com/trullock/chartjs-plugin-zoom which is published on npm as @trullock/chartjs-plugin-zoom, as this fork seems abandoned |
Member
|
@joshkel would you be able to resolve the merge conflicts in this?
I think its better to return a new object, as you did. |
kurkle
approved these changes
Nov 16, 2024
Contributor
Author
|
Thanks for taking care of this, @kurkle. I apologize for not following up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a function,
getZoomedScaleBounds, to act as a counterpart togetInitialScaleBounds(getting the scale ranges after zoom rather than before) andzoomScale(reading, rather than writing, each scale's zoom).A question for code review: Is it okay to return the internal object directly, or should I return a new object to ensure that it can't be mutated?