Skip to content

fix: explicit passive: false for wheel events to prevent warnings on console #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kurkle merged 1 commit into from
Nov 15, 2024
Merged

fix: explicit passive: false for wheel events to prevent warnings on console #856

kurkle merged 1 commit into from
Nov 15, 2024

Conversation

@kurkle
Copy link
Member

@kurkle kurkle commented Nov 14, 2024

fixes: #827
closes: #819

@kurkle kurkle added the bug label Nov 14, 2024
@github-actions
Copy link

github-actions bot commented Nov 14, 2024

Size Change: +162 B (+0.76%)

Total Size: 21.5 kB

Filename Size Change
dist/chartjs-plugin-zoom.esm.js 8.18 kB +72 B (+0.89%)
dist/chartjs-plugin-zoom.js 8.44 kB +73 B (+0.87%)
dist/chartjs-plugin-zoom.min.js 4.91 kB +17 B (+0.35%)

compressed-size-action

@kurkle kurkle requested a review from LeeLenaleee November 15, 2024 09:46
@kurkle kurkle merged commit 7704540 into master Nov 15, 2024
6 checks passed
@kurkle kurkle deleted the fix/chrome-warning branch November 15, 2024 09:53
@kurkle kurkle mentioned this pull request Nov 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Chrome warning - Added non-passive event listener to a scroll-blocking event Expose "passive" boolean in the EventListenerOptions dictionary.

3 participants

@kurkle @LeeLenaleee