Fix handling at canvas edge #898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkle
reviewed
Nov 21, 2024
Member
kurkle
left a comment
kurkle
left a comment
There was a problem hiding this comment.
Makes sense 👍
Some tests maybe? 🙂
Contributor
Author
|
@kurkle I have a test in my local branch at https://github.com/joshkel/chartjs-plugin-zoom/tree/local-2.1.0. It depends on #896 being merged. I can wait for that PR, or, if you'd rather have one PR that combines these fixes, I can do that. |
Member
joshkel
force-pushed
the
drag-canvas-edge
branch
from
6e8344a to
7bc7d8a
Compare
Contributor
Author
|
@kurkle Thanks. I've added tests. |
kurkle
approved these changes
Nov 21, 2024
Member
|
Thanks @joshkel I will add at least one more thing tomorrow and publish a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible fix for #897. Further testing may be needed.