fix: make handle_unilateral non-async #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am looking into the code of IDLE implementation because of chatmail/core#6477 |
Hocuri
approved these changes
Jan 28, 2025
link2xt
force-pushed
the
link2xt/handle_unilateral
branch
from
2c2309c to
73a5a1d
Compare
The check for `unsolicited.is_full()` at the beginning of `handle_unilateral` is not sufficient if the function is called from multiple threads parallel. This normally should not happen, but not guaranteed. Instead of checking if the channel is full in advance, use `tr_send` and ignore the error if the channel happens to be full when we try to send into it. We also ignore the error when the channel is closed instead of panic because the library should never panic.
link2xt
force-pushed
the
link2xt/handle_unilateral
branch
from
73a5a1d to
af55344
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for
unsolicited.is_full()at the beginning of
handle_unilateralis not sufficient if the function is called
from multiple threads parallel.
This normally should not happen,
but not guaranteed.
Instead of checking if the channel is full in advance, use
tr_sendand ignore the errorif the channel happens to be full
when we try to send into it.
We also ignore the error when the channel
is closed instead of panic
because the library should never panic.