refactor!: use try_next() more #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have looked through the code to make sure errors are not ignored, especially in loops. Ignoring errors in loops when reading from streams may result in infinite loop reading the same error over and over again. No bugs found, but I refactored reading from streams to use `try_next()` more to bubble up the errors with `?` as soon as possible. This is a breaking change since `read_response()` is resultified to return `Result<Option<_>>` instead of `Option<Result<_>>`. `read_response()` is a public interface that is used by library users to read the banner.
Hocuri
approved these changes
Jul 21, 2025
There was a problem hiding this comment.
I don't know this code, but I carefully read through the changes, and they look good as far as I can tell.
FTR, this PR is needed to protect against possible infinite loops like chatmail/core#6477. To quote @link2xt:
On error, repeated calls to
next()return
Some(Err(_)), and if you are looking forNone,
you may get stuck in infinite loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have looked through the code
to make sure errors are not ignored,
especially in loops.
Ignoring errors in loops
when reading from streams
may result in infinite loop
reading the same error over and over again.
No bugs found,
but I refactored reading from streams
to use
try_next()moreto bubble up the errors with
?as soon as possible.
This is a breaking change since
read_response()is resultified to returnResult<Option<_>>instead ofOption<Result<_>>.read_response()is a public interfacethat is used by library users
to read the banner.