refactor(mimeparser): store only one signature fingerprint #7119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Messages are normally not signed with more than one key and in this case we pick an arbitrary signature later anyway.
link2xt
force-pushed
the
link2xt/wzolsymnknrz
branch
from
67149fb to
165d785
Compare
iequidoo
reviewed
Aug 17, 2025
| @@ -571,7 +571,7 @@ impl MimeMessage { | |||
| decrypting_failed: mail.is_err(), | |||
|
|
|||
| // only non-empty if it was a valid autocrypt message | |||
| signatures, | |||
| signature: signatures.into_iter().next(), | |||
There was a problem hiding this comment.
Probably we must take the innermost signature because in merge_headers() we prefer protected headers from the inner part (we drop outer protected headers at all).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages are normally not signed with more than one key and in this case we pick an arbitrary signature later anyway.