fix: Mark message as failed if it can't be send #7143
Merged
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
approved these changes
Sep 1, 2025
| Ok(mf) => mf, | ||
| Err(err) => { | ||
| // Mark message as failed | ||
| message::set_msg_failed(context, msg, &err.to_string()) |
There was a problem hiding this comment.
Looks good, but if the app crashes before this call or for some other reason doesn't reach even the MimeFactory::from_msg() call, the message will remain OutPending. We need some additional recovery code path pushing such messages through create_send_msg_jobs() again, maybe somewhere in the SMTP loop.
There was a problem hiding this comment.
This PR already works in 99.9% of cases, which is good enough here - it's super unlikely that a) an outgoing message fails AND b) the app will by chance be killed at this exact moment. And if some outgoing message makes core crash (i.e. panic-abort), it's actually better not to process it again.
Hocuri
approved these changes
Sep 2, 2025
|
Thanks Nico for taking care of this. And sorry for replying late. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6849
I tested this fix with desktop as described in deltachat/deltachat-desktop#5414 and the behaviour is now as expected imo: showing a message with status failed