api: Add unpublished flag for transports#7994
Merged
Conversation
link2xt
reviewed
Mar 15, 2026
link2xt
reviewed
Mar 15, 2026
Hocuri
force-pushed
the
hoc/unpublished-addrs
branch
4 times, most recently
from
09521f6 to
b94d9f9
Compare
Hocuri
commented
Mar 17, 2026
| if context.get_config_bool(Config::BccSelf).await? | ||
| || msg.param.get_cmd() == SystemMessage::AutocryptSetupMessage | ||
| { | ||
| smtp::add_self_recipients(context, &mut recipients, rendered_msg.is_encrypted).await?; |
Collaborator
Author
There was a problem hiding this comment.
This change actually fixes an unrelated bug, and is necessary for the tests to pass: We need to pass is_encrypted to add_self_recipients(), not needs_encryption
Hocuri
force-pushed
the
hoc/unpublished-addrs
branch
from
b94d9f9 to
72c8c7b
Compare
Hocuri
changed the title
unpublished flag for transportsunpublished flag for transports
link2xt
approved these changes
Mar 17, 2026
| } | ||
| } | ||
|
|
||
| fn concat(slices: &[&[&'static str]]) -> Vec<&'static str> { |
Collaborator
There was a problem hiding this comment.
This can as well return BTreeSet since you always convert the vector into a set immediately.
Collaborator
Author
There was a problem hiding this comment.
Not always, I also use it for:
assert_eq!(
sent.recipients,
format!("bob@example.net {}", published_self_addrs.join(" ")),
[...]
)Just returning a Vec here seems easiest overall.
iequidoo
reviewed
Mar 18, 2026
Collaborator
iequidoo
left a comment
iequidoo
left a comment
There was a problem hiding this comment.
By default, transports are published, but when updating, all existing transports except for the primary one become unpublished in order not to break existing users that followed https://delta.chat/legacy-move
Btw, that guide says:
The option “Move automatically to DeltaChat Folder” as well as other legacy options will be removed in the next weeks.
But the guide itself doesn't have a publication date, so "next weeks" sounds unclear.
Hocuri
force-pushed
the
hoc/unpublished-addrs
branch
from
544212d to
a0ff35f
Compare
Hocuri
changed the title
unpublished flag for transportsunpublished flag for transports
Hocuri
force-pushed
the
hoc/unpublished-addrs
branch
3 times, most recently
from
87977a3 to
047b4d1
Compare
iequidoo
reviewed
Mar 18, 2026
…ctions Closes #7980. Unpublished transports are not advertised to contacts, and self-sent messages are not sent there, so that we don't cause extra messages to the corresponding inbox, but can still receive messages from contacts who don't know the new relay addresses yet. - This adds `list_transports_ex()` and `set_transport_unpublished()` JsonRPC functions - By default, transports are published, but when updating, all existing transports except for the primary one become unpublished in order not to break existing users that followed https://delta.chat/legacy-move - It is not possible to unpublish the primary transport, and setting a transport as primary automatically sets it to published An alternative would be to change the existing list_transports API rather than adding a new one list_transports_ex. But to be honest, I don't mind the _ex prefix that much, and I am wary about compatibility issues. But maybe it would be fine; see b08ba4b for how this would look.
Hocuri
force-pushed
the
hoc/unpublished-addrs
branch
from
047b4d1 to
8d999b7
Compare
Hocuri
added a commit
that referenced
this pull request
Mar 18, 2026
Follow-up to #7994, in order to prevent clashes with other things that are called `Transport`, and in order to make the struct name more greppable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7980. First commit moves some code around, second commit implements the unpublished flag.
Unpublished transports are not advertised to contacts, and self-sent messages are not sent there, so that we don't cause extra messages to the corresponding inbox, but can still receive messages from contacts who don't know the new relay addresses yet.
list_transports_ex()andset_transport_unpublished()JsonRPC functionsAn optional TODO would be to maybe change the existing list_transports API rather than adding a new one list_transports_ex. But to be honest, I don't mind the _ex prefix that much, and I am wary about compatibility issues. But maybe it would be fine; see b08ba4b for how this would look.