Skip to content

Conversation

@missytake
Copy link
Contributor

@missytake missytake commented Oct 8, 2025

Thanks @Keonik1 for #614 :) I had a lot of fun with git rebase to break it up into small, reviewable chunks. It's still a lot, but doable :)

Before we can merge this, we need to merge:

Additional related PRs:

With this PR, checking DNS records should already work; Getting tests to run with a docker instance is still a bit of work (see the docker-rebase...docker-tests branch for first steps).

So for now this will be an experimental feature which we can tell people to try out if they ask for it. But in the long term we need a separate CI machine for testing the docker setup, to be sure nothing breaks when we make changes.

@missytake missytake force-pushed the sshexec-docker branch 2 times, most recently from c35f186 to a1c2870 Compare October 14, 2025 18:44
Base automatically changed from sshexec-docker to sshexec-rework October 14, 2025 19:29
Base automatically changed from sshexec-rework to main October 14, 2025 20:27
@missytake missytake requested review from hpk42 and link2xt October 15, 2025 12:23
@missytake missytake force-pushed the docker-rebase branch 2 times, most recently from d12782f to 8541139 Compare October 17, 2025 11:27
@Keonik1
Copy link
Collaborator

Keonik1 commented Oct 26, 2025

So, I found some more problems with the installation via Docker, some of which seem to be related to changes that were lost during the transfer.
Some of them came from changes that were pulled from the master.

@Keonik1
Copy link
Collaborator

Keonik1 commented Oct 26, 2025

I created an issue with the main problem.

#694

Copy link
Collaborator

@Keonik1 Keonik1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also marked the lost changes. I haven't checked everything yet, but at least it won't work without this.

@github-actions
Copy link

Check out the page preview at https://staging.chatmail.at/doc/relay/664/

@missytake
Copy link
Contributor Author

I created an issue with the main problem.

#694

I added a commit for this :)

Also, I rebased this on main, so we can try it out again. It's a bit late now for me to re-deploy it, but I'll check tomorrow whether it still works as expected :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants