Skip to content

Conversation

@link2xt
Copy link
Contributor

@link2xt link2xt commented Nov 8, 2025

Took me a while to delete google.com and gogle.com requests that were restored over and over to merge #719

I also don't understand why rsync errors are ignored with || true everywhere.

@link2xt link2xt force-pushed the link2xt/ptrkrooonxtl branch 2 times, most recently from 16a36ac to cf875f1 Compare November 8, 2025 19:35
@link2xt link2xt force-pushed the link2xt/ptrkrooonxtl branch from cf875f1 to 1f1e645 Compare November 8, 2025 19:36
@missytake
Copy link
Contributor

Took me a while to delete google.com and gogle.com requests that were restored over and over to merge #719

Sorry for messing up our CI's acmetool state -.- I kinda forgot that it is kept, and failed to correctly clean up on ns.testrun.org after that.

I also don't understand why rsync errors are ignored with || true everywhere.

Because if a CI run fails before it acquires a /var/lib/acme and/or /etc/dkimkeys directory, it will make the next CI run fail; what we want in such a case is failing silently, so that later the last successful state from ns.testrun.org can be applied to the test VPS.

Also later we want to fail silently, without blocking the CI run - because if using the CI state which is cached on ns.testrun.org fails for some reason, we don't want the CI to stop, we want the CI run to create a new /var/lib/acme state, which is then later cached on ns.testrun.org during the next CI run.

What we could do - move the steps you modified to the very end of the CI workflow, so it only stores /var/lib/acme and /etc/dkimkeys on ns.testrun.org if the tests completed successfully. Then we could also use rsync --delete and give up on || true.

In the beginning I developed it like this, because we didn't have state on ns.testrun.org yet; now that we have, we can move the steps to the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants