fix: Remove Authentication-Results header and correct header iteration #799
Conversation
Header indices start from 0
j4n
had a problem deploying
to
staging2.testrun.org
GitHub Actions
Error
j4n
had a problem deploying
to
staging-ipv4.testrun.org
GitHub Actions
Error
| end | ||
|
|
||
| -- Delete first and presumably only occurence | ||
| odkim.del_header(ctx, "Authentication-Results", 0) |
There was a problem hiding this comment.
there can be multiple Authentication-Results headers IIRC see https://datatracker.ietf.org/doc/html/rfc7601#appendix-B.5
It's best to remove all.
There was a problem hiding this comment.
There is no mechanism to count these, as opposed to the DKIM headers; so the last commit just tries to delete up to 10 headers.
There can be more than one header
j4n
temporarily deployed
to
staging-ipv4.testrun.org
GitHub Actions
Inactive
j4n
temporarily deployed
to
staging2.testrun.org
GitHub Actions
Inactive
hpk42
left a comment
hpk42
left a comment
There was a problem hiding this comment.
ok, looks good but a test is missing and would be useful also after we phase in the dkim-milter approach. Test would need to:
-
use "maildomain2" to create an address and then send a message to mail_domain. See test_securejoin in test_2_deltachat.py
-
use eg "imap_tools" (grep for it) to retrieve the headers and checking if authentication-results or dkim signature headers are present in the mailbox (on maildomain).
could you try to add such a test?
Header indices start with 0; fix loop for purging DKIM headers, and also remove Authentication-Results header