Skip to content

feat: Support arm64 build#496

Merged
RomanNikitenko merged 6 commits intoche-incubator:mainfrom
tolusha:arm64
Feb 7, 2025
Merged

feat: Support arm64 build#496
RomanNikitenko merged 6 commits intoche-incubator:mainfrom
tolusha:arm64

Conversation

@tolusha
Copy link
Contributor

@tolusha tolusha commented Feb 3, 2025

What does this PR do?

Support arm64 build.
Images examples: https://quay.io/repository/abazko/che-code

What issues does this PR fix?

eclipse-che/che#23128

How to test this PR?

N/A

Does this PR contain changes that override default upstream Code-OSS behavior?

  • the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
  • the corresponding items were added to the CHANGELOG.md file
  • rules for automatic git rebase were added to the .rebase folder

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@github-actions
Copy link

github-actions bot commented Feb 3, 2025

Click here to review and test in web IDE: Contribute

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@RomanNikitenko
Copy link
Collaborator

RomanNikitenko commented Feb 5, 2025

@tolusha
I left few comments, other look good to me, thank you for adding arm64 support!

please align your branch with the main branch to resolve conflict

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@RomanNikitenko
Copy link
Collaborator

@azatsarynnyy
it looks like we need new mapping for the Required PR checks.

@azatsarynnyy
Copy link
Member

@azatsarynnyy it looks like we need new mapping for the Required PR checks.

@RomanNikitenko done

@vitaliy-guliy
Copy link
Contributor

vitaliy-guliy commented Feb 6, 2025

It's strange, there are should be all the che-code compilations in pull request check job artifacts

linux-libc-ubi8-amd64
linux-libc-ubi9-amd64
linux-musl-amd64

linux-libc-ubi8-arm64
linux-libc-ubi9-arm64
linux-musl-arm64

I see only linux-musl-arm64 here https://github.com/che-incubator/che-code/actions/runs/13159172315?pr=496

Just compare how it was before https://github.com/che-incubator/che-code/actions/runs/13182818163?pr=502

Upd. It seems it is something with GitHub itself.

@tolusha tolusha closed this Feb 7, 2025
@tolusha tolusha reopened this Feb 7, 2025
@RomanNikitenko
Copy link
Collaborator

RomanNikitenko commented Feb 7, 2025

@azatsarynnyy it looks like we need new mapping for the Required PR checks.

@RomanNikitenko done

@azatsarynnyy
thank you!

but there is still the problem
it looks like you need to remove the Required field for the old checks

@tolusha
Copy link
Contributor Author

tolusha commented Feb 7, 2025

@vitaliy-guliy
It shows 10 artifacts
I have no idea why github displays only 4

@RomanNikitenko RomanNikitenko merged commit 64d81ea into che-incubator:main Feb 7, 2025
22 checks passed
@devspacesbuild
Copy link

Build 3.20 :: code_3.x/1550: Console, Changes, Git Data

@tolusha tolusha deleted the arm64 branch February 7, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants