feat: add license check by olexii4 · Pull Request #527 · che-incubator/che-code

olexii4 · 2025-03-11T15:09:33Z

What does this PR do?

Add license check.

What issues does this PR fix?

fixes eclipse-che/che#23363

How to test this PR?

Does this PR contain changes that override default upstream Code-OSS behavior?

the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
the corresponding items were added to the CHANGELOG.md file
rules for automatic git rebase were added to the .rebase folder

github-actions · 2025-03-11T15:09:51Z

Click here to review and test in web IDE:

code/.deps/problems.md

github-actions · 2025-03-11T16:48:33Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-527-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-527-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-527-dev-amd64

vitaliy-guliy · 2025-03-12T06:18:52Z

Honestly, I do not have the whole picture of what this PR does.

Could we instead of adding all those files, add only one GitHub action, that will be triggered by pushing to the main branch (or pull request)? The action should not block anything and its successful execution may be represented as a badge in the README file.

olexii4 · 2025-03-12T13:36:37Z

Honestly, I do not have the whole picture of what this PR does.

Could we instead of adding all those files, add only one GitHub action, that will be triggered by pushing to the main branch (or pull request)? The action should not block anything and its successful execution may be represented as a badge in the README file.

@vitaliy-guliy We have some information here che-incubator/dash-licenses:

...
Update dependency info
The following command generates dependencies info of a project and then checks all found dependencies. It returns a non-zero exit code if any of them are restricted to use.

docker run --rm -t \
       -v ${PWD}/:/workspace/project  \
       quay.io/che-incubator/dash-licenses:next

As a result, this command creates the next files:

prod.md with the list of production dependencies;
dev.md which contains only build and test dependencies;
problems.md will be created if some dependencies are not covered with CQ, unnecessary excludes present, etc.

Check dependencies
If you just need to verify that all dependencies satisfy IP requirements, use the --check flag, like the following

docker run --rm -t \
       -v ${PWD}/:/workspace/project  \
       quay.io/che-incubator/dash-licenses:next --check

So, this command doesn't create any new files in the project directory (except a temporary one) but checks if the dependencies info is up-to-date and then validates all found dependencies. It returns a non-zero exit code if any of the dependencies are restricted to use.
...

Files prod.md and dev.md include license information for libraries. for example:

Production dependencies

Packages	License	Resolved CQs
`@vscode/sqlite3@5.1.8-vscode`	BSD-3-Clause	clearlydefined
...

You can click a link with CQ and the next page will be opened

github-actions · 2025-04-22T15:19:23Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-527-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-527-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-527-dev-amd64

github-actions · 2025-04-22T16:24:36Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-527-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-527-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-527-dev-amd64

RomanNikitenko

@olexii4
I propose to add section that describes license check functionality to the readme file
you could take this comment as a basis #527 (comment)

github-actions · 2025-04-25T13:14:31Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-527-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-527-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-527-dev-amd64

github-actions · 2025-04-28T14:33:15Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-527-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-527-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-527-dev-amd64

olexii4 · 2025-04-29T15:01:55Z

@olexii4 I propose to add section that describes license check functionality to the readme file you could take this comment as a basis #527 (comment)

@RomanNikitenko I have fixed it:

github-actions · 2025-04-29T15:57:17Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-527-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-527-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-527-dev-amd64

github-actions · 2025-04-29T16:05:59Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-527-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-527-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-527-dev-amd64

github-actions · 2025-04-29T16:18:49Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-527-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-527-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-527-dev-amd64

README.md

github-actions · 2025-04-30T15:22:08Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-527-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-527-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-527-dev-amd64

README.md

RomanNikitenko · 2025-05-02T08:38:40Z

@olexii4
ubi9-based build is failing, I created an issue for that problem eclipse-che/che#23424
#541 should fix the problem, waiting for the jobs...

RomanNikitenko · 2025-05-02T09:33:05Z

@olexii4
I've merged my fix, please fetch new changes from the main branch to fix che-code build in your PR

vitaliy-guliy · 2025-05-02T10:49:28Z

My first attempt of launching npm run license:generate has been failed.

I created a workspace from https://github.com/olexii4/che-code/tree/CHE-23363 and installed node dependencies. Then I added "comment-json": "4.2.5" dependency to che-api, installed dependency again and launched npm run license:generate command for che-api

Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 · 2025-05-02T12:54:43Z

My first attempt of launching npm run license:generate has been failed.

I created a workspace from https://github.com/olexii4/che-code/tree/CHE-23363 and installed node dependencies. Then I added "comment-json": "4.2.5" dependency to che-api, installed dependency again and launched npm run license:generate command for che-api

@vitaliy-guliy I updated the thread. Please try again.

olexii4 · 2025-05-02T15:35:50Z

@vitaliy-guliy I updated the thread. Please try again.

With the update podman doesn't even try to download the image

@olexii4 could you please update package-lock.json files for che-* extensions? This is what I have after installing node dependencies

$ git status
On branch CHE-23363
Your branch is up to date with 'origin/CHE-23363'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   code/extensions/che-activity-tracker/package-lock.json
        modified:   code/extensions/che-api/package-lock.json
        modified:   code/extensions/che-commands/package-lock.json
        modified:   code/extensions/che-port/package-lock.json
        modified:   code/extensions/che-remote/package-lock.json
        modified:   code/extensions/che-resource-monitor/package-lock.json

no changes added to commit (use "git add" and/or "git commit -a")

@vitaliy-guliy Why should I do it in this PR? It is a separate issue that doesn't depend on my changes.

vitaliy-guliy · 2025-05-02T17:16:11Z

@olexii4 could you please update package-lock.json files for che-* extensions? This is what I have after installing node dependencies

$ git status
On branch CHE-23363
Your branch is up to date with 'origin/CHE-23363'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   code/extensions/che-activity-tracker/package-lock.json
        modified:   code/extensions/che-api/package-lock.json
        modified:   code/extensions/che-commands/package-lock.json
        modified:   code/extensions/che-port/package-lock.json
        modified:   code/extensions/che-remote/package-lock.json
        modified:   code/extensions/che-resource-monitor/package-lock.json

no changes added to commit (use "git add" and/or "git commit -a")

@vitaliy-guliy Why should I do it in this PR? It is a separate issue that doesn't depend on my changes.

Ok, let's skip them as the changes are not related to this PR.

olexii4 · 2025-05-02T20:28:38Z

olexii4 · 2025-05-08T09:21:14Z

@vitaliy-guliy FYI: che-incubator/dash-licenses#26 was merged.

vitaliy-guliy · 2025-05-09T06:42:19Z

Let's merge this PR as it is.
In case of any issues, changes in this PR will not block creating and merging the pull requests and will not affect the main branch.

Signed-off-by: Oleksii Orel <oorel@redhat.com>

github-actions · 2025-05-19T11:18:02Z

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-527-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-527-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-527-dev-amd64

vitaliy-guliy · 2025-05-19T12:58:37Z

@olexii4 thanks for the contribution!

devspacesbuild · 2025-05-19T12:59:38Z

Build 3.22 :: code_3.x/1597: Console, Changes, Git Data

devspacesbuild · 2025-05-19T13:02:27Z

Build 3.22 :: sync-to-downstream_3.x/9332: Console, Changes, Git Data

devspacesbuild · 2025-05-19T13:03:21Z

Build 3.22 :: get-sources-rhpkg-container-build_3.x/9480: Console, Changes, Git Data

devspacesbuild · 2025-05-19T15:57:44Z

Build 3.22 :: push-latest-container-to-quay_3.x/5176: Console, Changes, Git Data

devspacesbuild · 2025-05-19T16:00:18Z

Build 3.22 :: get-sources-rhpkg-container-build_3.x/9480:

code : 3.x :: Build 67663476 : quay.io/devspaces/code-rhel9:3.22-5
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/5176 triggered

devspacesbuild · 2025-05-19T16:00:21Z

Build 3.22 :: update-digests_3.x/9233: Console, Changes, Git Data

devspacesbuild · 2025-05-19T16:00:22Z

Build 3.22 :: code_3.x/1597:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/9332 triggered

devspacesbuild · 2025-05-19T16:01:56Z

Build 3.22 :: operator-bundle_3.x/4909: Console, Changes, Git Data

devspacesbuild · 2025-05-19T16:05:05Z

Build 3.22 :: sync-to-downstream_3.x/9333: Console, Changes, Git Data

devspacesbuild · 2025-05-19T16:10:11Z

Build 3.22 :: get-sources-rhpkg-container-build_3.x/9481: Console, Changes, Git Data

devspacesbuild · 2025-05-19T16:17:18Z

Build 3.22 :: push-latest-container-to-quay_3.x/5177: Console, Changes, Git Data

devspacesbuild · 2025-05-19T16:20:25Z

Build 3.22 :: copyIIBsToQuay/2999: Console, Changes, Git Data

devspacesbuild · 2025-05-19T16:21:20Z

Build 3.22 :: get-sources-rhpkg-container-build_3.x/9481:

devspaces-operator-bundle : 3.x :: Build 67665664 : quay.io/devspaces/devspaces-operator-bundle:3.22-13
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/5177 triggered;
Bundle CSV related images:
- quay.io/devspaces-tech-preview/idea-rhel9:
- quay.io/devspaces-tech-preview/jetbrains-ide-rhel9:
- quay.io/devspaces/code-rhel9:3.22-5
- quay.io/devspaces/configbump-rhel9:3.22-2
- quay.io/devspaces/dashboard-rhel9:3.22-7
- quay.io/devspaces/devspaces-rhel9-operator:3.22-2
- quay.io/devspaces/pluginregistry-rhel9:3.22-2
- quay.io/devspaces/server-rhel9:3.22-5
- quay.io/devspaces/traefik-rhel9:3.22-1
- quay.io/devspaces/udi-rhel9:3.22-3
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.14.0-202504220036.p0.gb8b8259.assembly.stream.el8
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.14.0-202504220036.p0.ga4a2f27.assembly.stream.el8
= registry.redhat.io/ubi8/ubi-minimal:8.8-1072.1697626218

devspacesbuild · 2025-05-19T16:21:23Z

Build 3.22 :: sync-to-downstream_3.x/9333:

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/9481 triggered; /job/DS_CI/job/dsc_3.x triggered;

devspacesbuild · 2025-05-19T16:21:24Z

Build 3.22 :: operator-bundle_3.x/4909:

Upstream sync done; /DS_CI/sync-to-downstream_3.x/9333 triggered

devspacesbuild · 2025-05-19T16:22:46Z

Build 3.22 :: dsc_3.x/2054: Console, Changes, Git Data

devspacesbuild · 2025-05-19T16:23:53Z

Build 3.22 :: update-digests_3.x/9233:

Detected new images: rebuild operator-bundle
* code; /DS_CI/operator-bundle_3.x/4909 triggered

devspacesbuild · 2025-05-19T16:31:33Z

Build 3.22 :: dsc_3.x/2054:

3.22.0-CI

olexii4 mentioned this pull request Mar 11, 2025

[che-code] Add a GitHub job to check licenses for using libraries for PRs eclipse-che/che#23363

Closed

RomanNikitenko reviewed Mar 11, 2025

View reviewed changes

code/.deps/problems.md Outdated Show resolved Hide resolved

olexii4 mentioned this pull request Apr 16, 2025

[dash-licenses] Add a IP Team Review request feature to automatically set up a review eclipse-che/che#23397

Closed

olexii4 marked this pull request as ready for review April 22, 2025 14:03

olexii4 requested review from azatsarynnyy and vitaliy-guliy as code owners April 22, 2025 14:03

olexii4 marked this pull request as draft April 23, 2025 00:40

olexii4 marked this pull request as ready for review April 23, 2025 13:22

RomanNikitenko reviewed Apr 25, 2025

View reviewed changes

RomanNikitenko reviewed Apr 30, 2025

View reviewed changes

README.md Outdated Show resolved Hide resolved

RomanNikitenko reviewed May 1, 2025

View reviewed changes

README.md Outdated Show resolved Hide resolved

RomanNikitenko approved these changes May 1, 2025

View reviewed changes

feat: add license check

b65b3e4

Signed-off-by: Oleksii Orel <oorel@redhat.com>

vitaliy-guliy approved these changes May 9, 2025

View reviewed changes

vitaliy-guliy mentioned this pull request May 14, 2025

Podman run :: missing files in the volume after installing node dependencies eclipse-che/che#23439

Closed

feat: add license check

449b897

Signed-off-by: Oleksii Orel <oorel@redhat.com>

vitaliy-guliy merged commit 673a87e into che-incubator:main May 19, 2025
13 of 14 checks passed

olexii4 deleted the CHE-23363 branch May 19, 2025 12:59

Conversation

olexii4 commented Mar 11, 2025

What does this PR do?

What issues does this PR fix?

How to test this PR?

Does this PR contain changes that override default upstream Code-OSS behavior?

Uh oh!

github-actions bot commented Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 11, 2025

Uh oh!

vitaliy-guliy commented Mar 12, 2025

Uh oh!

olexii4 commented Mar 12, 2025

Production dependencies

Uh oh!

github-actions bot commented Apr 22, 2025

Uh oh!

github-actions bot commented Apr 22, 2025

Uh oh!

RomanNikitenko left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 25, 2025

Uh oh!

github-actions bot commented Apr 28, 2025

Uh oh!

olexii4 commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 29, 2025

Uh oh!

github-actions bot commented Apr 29, 2025

Uh oh!

github-actions bot commented Apr 29, 2025

Uh oh!

Uh oh!

github-actions bot commented Apr 30, 2025

Uh oh!

Uh oh!

RomanNikitenko commented May 2, 2025

Uh oh!

RomanNikitenko commented May 2, 2025

Uh oh!

vitaliy-guliy commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

olexii4 commented May 2, 2025

Uh oh!

olexii4 commented May 2, 2025

Uh oh!

vitaliy-guliy commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

olexii4 commented May 2, 2025

Uh oh!

olexii4 commented May 8, 2025

Uh oh!

vitaliy-guliy commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 19, 2025

Uh oh!

Uh oh!

vitaliy-guliy commented May 19, 2025

Uh oh!

devspacesbuild commented May 19, 2025

Uh oh!

devspacesbuild commented May 19, 2025

Uh oh!

devspacesbuild commented May 19, 2025

Uh oh!

devspacesbuild commented May 19, 2025

Uh oh!

devspacesbuild commented May 19, 2025

Uh oh!

devspacesbuild commented May 19, 2025

Uh oh!

github-actions bot commented Mar 11, 2025 •

edited

Loading

olexii4 commented Apr 29, 2025 •

edited

Loading

vitaliy-guliy commented May 2, 2025 •

edited

Loading

vitaliy-guliy commented May 2, 2025 •

edited

Loading

vitaliy-guliy commented May 9, 2025 •

edited

Loading