Skip to content

Set up SSHD service entirely within sshd.start. #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rgrunber wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Set up SSHD service entirely within sshd.start. #606

rgrunber wants to merge 3 commits into from
+106 −54

Conversation

@rgrunber
Copy link
Collaborator

@rgrunber rgrunber commented Dec 3, 2025 •
edited
Loading

This requires eclipse-che/che-operator#2066 (for the editor definiton part)

  • Use a volume, /sshd/ that can be used to share SSHD resources (/usr/sbin/sshd, /usr/bin/ssh-keygen, /etc/ssh sshd_config, sshd.start) across containers
  • Use nss_wrapper to ensure default (random) user has a login shell (instead of /sbin/nologin) and a writeable home folder
  • Set home folder to /var/tmp/user if container has set it to / in passwd and for HOME
  • Prepend exec to (final) SSHD daemon startup in script
  • Fixes https://issues.redhat.com/browse/CRW-9647

@rgrunber rgrunber marked this pull request as draft December 3, 2025 18:05
@github-actions
Copy link

github-actions bot commented Dec 3, 2025 •
edited
Loading

Click here to review and test in web IDE: Contribute

@rgrunber rgrunber mentioned this pull request Dec 3, 2025
Open
3 tasks
rgrunber
rgrunber commented Dec 3, 2025
View reviewed changes
rgrunber
rgrunber commented Dec 3, 2025
View reviewed changes
rgrunber
rgrunber commented Dec 3, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-606-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-606-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-606-dev-amd64

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-606-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-606-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-606-dev-amd64

rgrunber
rgrunber commented Jan 8, 2026
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-606-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-606-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-606-dev-amd64

@rgrunber rgrunber marked this pull request as ready for review January 9, 2026 16:23
@rgrunber
Clean up calculation for the Dev Spaces host name.
fdd60f9 
- Set SSHD LogLevel from DEBUG3 to DEBUG1 for reduction in log file size
- Add basic documentation to CSS file

Signed-off-by: Roland Grunberg <[email protected]>
@rgrunber
Set up SSHD service entirely within sshd.start.
a6cf568 
- Use a volume, /sshd/ that can be used to share SSHD resources
  (/usr/sbin/sshd, /usr/bin/ssh-keygen, /etc/ssh/sshd_config,
  sshd.start, tools, dynamic libs) across containers
- Use nss_wrapper to ensure default (random) user has a login shell
  (instead of /sbin/nologin) and a writeable home folder
- Set home folder to /var/tmp/user if container has set it to / in
  passwd and for HOME
- Use LD_PRELOAD to include required libraries in minimal containers
- Place common tools on PATH using .profile & .bashrc
- Prepend exec to (final) SSHD daemon startup in script

Assisted-By: Gemini 2.5 Flash
Signed-off-by: Roland Grunberg <[email protected]>
@rgrunber
Use ubi9-nodejs-20-minimal image as base for che-code-sshd.
0284bf9 
Signed-off-by: Roland Grunberg <[email protected]>
@github-actions
Copy link

github-actions bot commented Jan 16, 2026

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-606-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-606-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-606-dev-amd64

1 similar comment
@github-actions
Copy link

github-actions bot commented Jan 16, 2026

Pull Request images published ✨

Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-606-amd64
Editor arm64: quay.io/che-incubator-pull-requests/che-code:pr-606-arm64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-606-dev-amd64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azatsarynnyy azatsarynnyy Awaiting requested review from azatsarynnyy azatsarynnyy is a code owner

@RomanNikitenko RomanNikitenko Awaiting requested review from RomanNikitenko RomanNikitenko is a code owner

@vitaliy-guliy vitaliy-guliy Awaiting requested review from vitaliy-guliy vitaliy-guliy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rgrunber