feat: resolve declaration files (e.g. .d.ts) as a last resort [sc-23313]
#1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that some users are using declaration files as shared header files and there is nothing else to resolve. During normal transpilation, any such imports would get removed and the declaration file would not be part of the dist bundle. Since we transpile on the runner, it would be nice to have the file available there even though it's not technically even required. More importantly however this change makes the parser not complain about missing dependencies if it encounters imports that can only be resolved to a declaration file.
|
🎉 Experimental release successfully published on npm |
sorccu
deleted the
simokinnunen/sc-23313/cli-resolve-declaration-files-as-a-last-resort
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that some users are using declaration files as shared header files and there is nothing else to resolve. During normal transpilation, any such imports would get removed and the declaration file would not be part of the dist bundle. Since we transpile on the runner, it would be nice to have the file available there even though it's not technically even required. More importantly however this change makes the parser not complain about missing dependencies if it encounters imports that can only be resolved to a declaration file.
I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components
Notes for the Reviewer
New Dependency Submission