chore: update oclif [sc-23314] #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@sorccu tests are still failing. I will hold off on review till they pass. |
sorccu
force-pushed
the
simokinnunen/sc-23314/cli-update-oclif
branch
from
955bf6a to
827b222
Compare
Member
|
@sorccu I actually would vote to introduce full stack traces. I find it very annoying to debug our current CLI as it does not print usable runtime exceptions due to the missing stack traces. Maybe we can switch it based on a |
Replaces removed ux.wait() with stdlib, ux.prompt() with prompts. Minor changes to bin files were also required as otherwise errors were printed with stack traces. I had not realized that the create-cli bin was checking Node version - it has now been updated to Node 18 too. The new oclif also requires Node 18. Custom help output had some type changes but is basically the same.
sorccu
force-pushed
the
simokinnunen/sc-23314/cli-update-oclif
branch
from
827b222 to
67b2a30
Compare
…erly This makes no sense but if topicSeparator is not present or is set to `":"`, CLI errors such as attempting to run `bin/run foo` in the packages/create-cli folder will error with a stack trace, with the error being thrown and handled (incorrectly) by oclif itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces removed ux.wait() with stdlib, ux.prompt() with prompts.
Minor changes to bin files were also required as otherwise errors were printed with stack traces. I had not realized that the create-cli bin was checking Node version - it has now been updated to Node 18 too. The new oclif also requires Node 18.
The
defaultcommand which was used for thecreate-clino longer exists and was replaced with thesinglecommand strategy.Custom help output had some type changes but is basically the same.
Note: for whatever reason we now MUST set the oclif
topicSeparator. This makes no sense but if topicSeparator is not present or is set to":", CLI errors such as attempting to runbin/run fooin the packages/create-cli folder will error with a stack trace, with the error being thrown and handled (incorrectly) by oclif itself.I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components
Notes for the Reviewer
New Dependency Submission