fix: make sure that we can send frequency = 0 to the API #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
sorccu
force-pushed
the
simo/sim-165-url-monitor-frequency-not-applying-correctly-via-terraform
branch
from
507eea1 to
bf5a64a
Compare
sorccu
deleted the
simo/sim-165-url-monitor-frequency-not-applying-correctly-via-terraform
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Components
Style
go fmtNotes for the Reviewer
Some monitor types had
Frequencyset toomitempty, which meant that high frequency monitors could not be created. Theomitemptywas removed. This introduces slight breakage asFrequencyis now effectively a required property, whereas earlier it would have used the API default if not set. However, since we are the main user and fixing the issue is more important, the breakage is acceptable.New Dependency Submission