Fix: Handle NoContent and null response in DeserializeResponseAsync #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
armando-rodriguez-cko
force-pushed
the
bugfix/fix-handle-no-content-and-null-response
branch
3 times, most recently
from
e5da261 to
ba48c90
Compare
armando-rodriguez-cko
force-pushed
the
bugfix/fix-handle-no-content-and-null-response
branch
3 times, most recently
from
601ae9a to
7eacd64
Compare
armando-rodriguez-cko
force-pushed
the
bugfix/fix-handle-no-content-and-null-response
branch
from
7eacd64 to
5660320
Compare
robert-goheen-cko
requested changes
Mar 17, 2025
armando-rodriguez-cko
force-pushed
the
bugfix/fix-handle-no-content-and-null-response
branch
from
5660320 to
a2e76ea
Compare
robert-goheen-cko
approved these changes
Mar 17, 2025
armando-rodriguez-cko
deleted the
bugfix/fix-handle-no-content-and-null-response
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Handle NoContent and null response in DeserializeResponseAsync
Key Changes
This PR enhances the
DeserializeResponseAsyncmethod inApiClientto handle cases where the HTTP response has no content (204 No Content) or whenhttpResponse.Contentisnull. It prevents potential exceptions when accessingContentLengthon anullcontent.Changes
httpResponse.Contentbefore accessingContentLength.DeserializeResponseAsynccorrectly returns an empty instance for204 No Contentresponses.Why is this needed?
Previously, if the response was
204 No Contentor hadnullcontent,DeserializeResponseAsynccould throw aNullReferenceException. This fix improves stability and ensures graceful handling of such cases.