refactor: introduce AuthenticationClient and reorganise authentication standalone module #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
test/CheckoutSdkTest/Authentification/Standalone/AuthenticationClientTest.cs
Fixed
Show fixed
Hide fixed
test/CheckoutSdkTest/Authentification/Standalone/AuthenticationClientTest.cs
Fixed
Show fixed
Hide fixed
armando-rodriguez-cko
force-pushed
the
refactor/authentication-standalone
branch
3 times, most recently
from
db16019 to
6f4c4b9
Compare
armando-rodriguez-cko
force-pushed
the
refactor/authentication-standalone
branch
from
6f4c4b9 to
515885b
Compare
|
gustavo-porto-cko
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new authentication client and supporting types for session-based authentication, refactors session credential handling, and adds comprehensive models for account information. The main themes are the addition of the
AuthenticationClientand its interface, the migration and extension of account info types, and the reorganization of session credential code.Authentication Client Implementation:
AuthenticationClientclass implementing session-based authentication flows, including methods for requesting, updating, completing, and retrieving session details, with support for both SDK and session secret authorization. (AuthenticationClient.cs)IAuthenticationClientinterface to specify the contract for session authentication operations. (IAuthenticationClient.cs)Account Information Models:
AccountInfomodel class with detailed properties for cardholder account history, authentication, and activity, including supporting enums for account age, change indicators, password change indicators, and more. (AccountInfo.cs,AccountAgeType.cs,AccountChangeIndicatorType.cs,AccountPasswordChangeIndicatorType.cs,AccountType.cs,CardholderAccountAgeIndicatorType.cs,ShippingAddressAgeType.cs,AuthenticationMethodType.cs) [1] [2] [3] [4] [5] [6] [7] [8]Session Credentials Refactoring:
SessionSecretSdkCredentialsfrom theSessionsnamespace toAuthentication, aligning it with the new authentication client structure. (SessionSecretSdkCredentials.cs)Enum and Type Consolidation:
AuthenticationMethodType.cs, other enum files above) [1] [2] [3] [4] [5] [6] [7]These changes collectively provide a robust foundation for session-based authentication and richer account information management within the SDK.