Refactor properties to nullable types for improved flexibility in authentication models

src/CheckoutSdk/Authentication/Standalone/Common/AccountInfo/AccountInfo.cs

@@ -13,7 +13,7 @@ public class AccountInfo
         /// [Optional]
         /// [ 0 .. 9999 ]
         /// </summary>
-        public double PurchaseCount { get; set; }
+        public long? PurchaseCount { get; set; }
 
         /// <summary>
         /// The length of time that the payment account was enrolled in the cardholder's account.
@@ -26,7 +26,7 @@ public class AccountInfo
         /// [Optional]
         /// [ 0 .. 999 ]
         /// </summary>
-        public double AddCardAttempts { get; set; }
+        public long? AddCardAttempts { get; set; }
 
         /// <summary>
         /// Indicates when the shipping address used for this transaction was first used.
@@ -38,21 +38,21 @@ public class AccountInfo
         /// Indicates if the Cardholder Name on the account is identical to the shipping Name used for this transaction.
         /// [Optional]
         /// </summary>
-        public bool AccountNameMatchesShippingName { get; set; }
+        public bool? AccountNameMatchesShippingName { get; set; }
 
         /// <summary>
         /// Indicates whether suspicious activity on the cardholder account has been observed.
         /// [Optional]
         /// </summary>
-        public bool SuspiciousAccountActivity { get; set; }
+        public bool? SuspiciousAccountActivity { get; set; }
 
         /// <summary>
         /// The number of transactions (successful and abandoned) for the cardholder account across all payment accounts
         /// in the previous 24 hours
         /// [Optional]
         /// [ 0 .. 999 ]
         /// </summary>
-        public double TransactionsToday { get; set; }
+        public long? TransactionsToday { get; set; }
 
         /// <summary>
         /// [DEPRECATED]
@@ -77,7 +77,7 @@ public class AccountInfo
         /// [Optional]
         /// <date-time>
         /// </summary>
-        public DateTime AccountChange { get; set; }
+        public DateTime? AccountChange { get; set; }
 
         /// <summary>
         /// The amount of time since the cardholder’s account information with the 3DS Requestor was last changed.
@@ -94,15 +94,15 @@ public class AccountInfo
         /// [Optional]
         /// <date-time>
         /// </summary>
-        public DateTime AccountDate { get; set; }
+        public DateTime? AccountDate { get; set; }
 
         /// <summary>
         /// The UTC date and time the cardholder’s account with the 3DS Requestor was last reset or had a password
         /// change, in ISO 8601 format.
         /// [Optional]
         /// <date-time>
         /// </summary>
-        public DateTime AccountPasswordChange { get; set; }
+        public DateTime? AccountPasswordChange { get; set; }
 
         /// <summary>
         /// The amount of time since the cardholder’s account with the 3DS Requestor was last reset or had a password
@@ -119,23 +119,23 @@ public class AccountInfo
         /// <= 3
         /// <= 999
         /// </summary>
-        public int TransactionsPerYear { get; set; }
+        public long? TransactionsPerYear { get; set; }
 
         /// <summary>
         /// The UTC date and time the payment account was enrolled in the cardholder’s account with the 3DS Requestor,
         /// in ISO 8601 format.
         /// [Optional]
         /// <date-time>
         /// </summary>
-        public DateTime PaymentAccountAge { get; set; }
+        public DateTime? PaymentAccountAge { get; set; }
 
         /// <summary>
         /// The UTC date and time the shipping address used for the transaction was first used with the 3DS Requestor,
         /// in ISO 8601 format.
         /// [Optional]
         /// <date-time>
         /// </summary>
-        public DateTime ShippingAddressUsage { get; set; }
+        public DateTime? ShippingAddressUsage { get; set; }
 
         /// <summary>
         /// The type of account, in the case of a card product with multiple accounts.

src/CheckoutSdk/Authentication/Standalone/Common/AccountInfo/ThreeDsRequestorAuthenticationInfo/ThreeDsRequestorAuthenticationInfo.cs

@@ -19,7 +19,7 @@ public class ThreeDsRequestorAuthenticationInfo
         /// [Optional]
         /// <date-time>
         /// </summary>
-        public DateTime ThreeDsReqAuthTimestamp { get; set; }
+        public DateTime? ThreeDsReqAuthTimestamp { get; set; }
 
         /// <summary>
         /// Data that documents and supports a specific authentication process.

src/CheckoutSdk/Authentication/Standalone/Common/Installment/Installment.cs

@@ -17,14 +17,14 @@ public class Installment
         public int NumberOfPayments { get; set; }
 
         /// <summary>
-        /// Default:  1 Indicates the minimum number of days between authorisations. If no value is specified for an
+        /// Default: 1 Indicates the minimum number of days between authorisations. If no value is specified for an
         /// installment authentication type the default value will be used.
         /// [Optional]
         /// </summary>
-        public int DaysBetweenPayments { get; set; } = 1;
+        public int? DaysBetweenPayments { get; set; } = 1;
 
         /// <summary>
-        /// Default:  99991231 Date after which no further authorisations are performed in the format yyyyMMdd. If no
+        /// Default: 99991231 Date after which no further authorisations are performed in the format yyyyMMdd. If no
         /// value is specified for an installment authentication type the default value will be used.
         /// [Optional]
         /// </summary>

src/CheckoutSdk/Authentication/Standalone/Common/MerchantRiskInfo/MerchantRiskInfo.cs

@@ -1,3 +1,4 @@
+using Checkout.Common;
 using System;
 
 namespace Checkout.Authentication.Standalone.Common.MerchantRiskInfo
@@ -26,13 +27,13 @@ public class MerchantRiskInfo
         /// date.
         /// [Optional]
         /// </summary>
-        public bool IsPreorder { get; set; }
+        public bool? IsPreorder { get; set; }
 
         /// <summary>
         /// Indicates whether the cardholder is reordering previously purchased merchandise.
         /// [Optional]
         /// </summary>
-        public bool IsReorder { get; set; }
+        public bool? IsReorder { get; set; }
 
         /// <summary>
         /// Indicates the shipping method chosen for the transaction. Please choose an option that accurately describes
@@ -59,7 +60,7 @@ public class MerchantRiskInfo
         /// [Optional]
         /// <date-time>
         /// </summary>
-        public DateTime PreOrderDate { get; set; }
+        public DateTime? PreOrderDate { get; set; }
 
         /// <summary>
         /// The total purchase amount, in major units. For example, the major unit amount for a gift card purchase of
@@ -75,7 +76,7 @@ public class MerchantRiskInfo
         /// [Optional]
         /// 3 characters
         /// </summary>
-        public string GiftCardCurrency { get; set; }
+        public Currency? GiftCardCurrency { get; set; }
 
         /// <summary>
         /// The total number of individual prepaid cards, gift cards, or gift codes purchased. Only applicable for

src/CheckoutSdk/Authentication/Standalone/Common/Recurring/Recurring.cs

@@ -8,14 +8,14 @@ namespace Checkout.Authentication.Standalone.Common.Recurring
     public class Recurring
     {
         /// <summary>
-        /// Default:  1 Indicates the minimum number of days between authorisations. If no value is specified for a
+        /// Default: 1 Indicates the minimum number of days between authorisations. If no value is specified for a
         /// recurring authentication type the default value will be used.
         /// [Optional]
         /// </summary>
-        public int DaysBetweenPayments { get; set; } = 1;
+        public int? DaysBetweenPayments { get; set; } = 1;
 
         /// <summary>
-        /// Default:  99991231 Date after which no further authorisations are performed in the format yyyyMMdd. If no
+        /// Default: 99991231 Date after which no further authorisations are performed in the format yyyyMMdd. If no
         /// value is specified for a recurring authentication type the default value will be used.
         /// [Optional]
         /// </summary>

src/CheckoutSdk/Authentication/Standalone/Common/Responses/Card/Metadata/Metadata.cs

@@ -1,3 +1,5 @@
+using Checkout.Common;
+
 namespace Checkout.Authentication.Standalone.Common.Responses.Card.Metadata
 {
     /// <summary>
@@ -28,7 +30,7 @@ public class Metadata
         /// The two letter alpha country code of the card issuer.
         /// [Optional]
         /// </summary>
-        public string IssuerCountry { get; set; }
+        public CountryCode? IssuerCountry { get; set; }
 
         /// <summary>
         /// The issuer/card scheme product identifier.

src/CheckoutSdk/Authentication/Standalone/Common/Responses/Certificates/Certificates.cs

@@ -31,6 +31,6 @@ public class Certificates
         /// server (ACS). Each array element is a Base64 URL-encoded DER-encoded X.509 certificate.
         /// [Optional]
         /// </summary>
-        public IList<object> CaPublicAll { get; set; }
+        public IList<string> CaPublicAll { get; set; }
     }
 }

src/CheckoutSdk/Authentication/Standalone/Common/Responses/GoogleSpa/Token/Token.cs

@@ -16,12 +16,12 @@ public class Token
         /// Expiry month of the token
         /// [Optional]
         /// </summary>
-        public double ExpiryMonth { get; set; }
+        public int? ExpiryMonth { get; set; }
 
         /// <summary>
         /// Expiry year of the token
         /// [Optional]
         /// </summary>
-        public double ExpiryYear { get; set; }
+        public int? ExpiryYear { get; set; }
     }
 }

src/CheckoutSdk/Authentication/Standalone/Common/Responses/Optimization/Optimization.cs

@@ -12,7 +12,7 @@ public class Optimization
         /// Indicates if any optimization has been applied
         /// [Optional]
         /// </summary>
-        public bool Optimized { get; set; }
+        public bool? Optimized { get; set; }
 
         /// <summary>
         /// The optimization framework applied

src/CheckoutSdk/Authentication/Standalone/Common/Responses/PreferredExperiences/GoogleSpa/GoogleSpa.cs

@@ -17,6 +17,6 @@ public class GoogleSpa
         /// Reason(s) why processing the experience was unsuccessful.
         /// [Optional]
         /// </summary>
-        public IList<object> Reason { get; set; }
+        public IList<string> Reason { get; set; }
     }
 }

src/CheckoutSdk/Authentication/Standalone/Common/Responses/PreferredExperiences/Threeds/Threeds.cs

@@ -17,6 +17,6 @@ public class Threeds
         /// Reason(s) why processing the experience was unsuccessful.
         /// [Optional]
         /// </summary>
-        public IList<object> Reason { get; set; }
+        public IList<string> Reason { get; set; }
     }
 }

src/CheckoutSdk/Authentication/Standalone/GETSessionsId/Responses/GetSessionDetailsResponseOk/GetSessionDetailsResponseOk.cs

@@ -15,6 +15,7 @@
 using Checkout.Authentication.Standalone.Common.Responses.SchemeInfo;
 using Checkout.Authentication.Standalone.Common.Responses.Threeds;
 using Checkout.Common;
+using Newtonsoft.Json;
 using System;
 using System.Collections.Generic;
 using ChallengeIndicatorType = Checkout.Authentication.Standalone.Common.Responses.ChallengeIndicatorType;
@@ -55,7 +56,7 @@ public class GetSessionDetailsResponseOk : Resource
         /// [Required]
         /// [ 0 .. 9223372036854776000 ]
         /// </summary>
-        public int Amount { get; set; }
+        public long Amount { get; set; }
 
         /// <summary>
         /// The three-letter ISO currency code
@@ -64,14 +65,14 @@ public class GetSessionDetailsResponseOk : Resource
         public Currency? Currency { get; set; }
 
         /// <summary>
-        /// Default:  "regular" Indicates the type of payment this session is for. Please note the spelling of
+        /// Default: "regular" Indicates the type of payment this session is for. Please note the spelling of
         /// installment consists of two ls.
         /// [Required]
         /// </summary>
         public AuthenticationType AuthenticationType { get; set; } = AuthenticationType.Regular;
 
         /// <summary>
-        /// Default:  "payment" Indicates the category of the authentication request
+        /// Default: "payment" Indicates the category of the authentication request
         /// [Required]
         /// </summary>
         public AuthenticationCategoryType AuthenticationCategory { get; set; } = AuthenticationCategoryType.Payment;
@@ -90,7 +91,7 @@ public class GetSessionDetailsResponseOk : Resource
         public string ProtocolVersion { get; set; }
 
         /// <summary>
-        /// Default:  "no_preference" Indicates the preference for whether or not a 3DS challenge should be performed.
+        /// Default: "no_preference" Indicates the preference for whether or not a 3DS challenge should be performed.
         /// The customer’s bank has the final say on whether or not the customer receives the challenge
         /// [Required]
         /// </summary>
@@ -110,14 +111,14 @@ public class GetSessionDetailsResponseOk : Resource
         /// Indicates whether this session has been completed
         /// [Optional]
         /// </summary>
-        public bool Completed { get; set; }
+        public bool? Completed { get; set; }
 
         /// <summary>
         /// Indicates whether this session involved a challenge. This will only be set after communication with the
         /// scheme is finished.
         /// [Optional]
         /// </summary>
-        public bool Challenged { get; set; }
+        public bool? Challenged { get; set; }
 
         /// <summary>
         /// Public certificates specific to a Directory Server (DS) for encrypting device data and verifying ACS signed
@@ -142,7 +143,7 @@ public class GetSessionDetailsResponseOk : Resource
         /// Whether the authentication was successful. This will only be set if the Session is in a final state
         /// [Optional]
         /// </summary>
-        public bool Approved { get; set; }
+        public bool? Approved { get; set; }
 
         /// <summary>
         /// Additional information about the Cardholder's account.
@@ -165,11 +166,11 @@ public class GetSessionDetailsResponseOk : Resource
         public string Reference { get; set; }
 
         /// <summary>
-        /// Default:  "goods_service" Identifies the type of transaction being authenticated
+        /// Default: "goods_service" Identifies the type of transaction being authenticated
         /// [Optional]
         /// <= 50
         /// </summary>
-        public TransactionType TransactionType { get; set; } = TransactionType.GoodsService;
+        public TransactionType? TransactionType { get; set; } = Common.TransactionType.GoodsService;
 
         /// <summary>
         /// Specifies which action to take in order to complete the session.
@@ -286,7 +287,7 @@ public class GetSessionDetailsResponseOk : Resource
         /// [Optional]
         /// <date-time>
         /// </summary>
-        public DateTime AuthenticationDate { get; set; }
+        public DateTime? AuthenticationDate { get; set; }
 
         /// <summary>
         /// Details related to exemption present in 3DS flow
@@ -316,6 +317,7 @@ public class GetSessionDetailsResponseOk : Resource
         /// This object provides more information about the 3DS experience
         /// [Optional]
         /// </summary>
+        [JsonProperty(PropertyName = "3ds")] 
         public Threeds Threeds { get; set; }
 
         /// <summary>

src/CheckoutSdk/Authentication/Standalone/POSTSessions/Requests/RequestASessionRequest/ChannelData/AbstractChannelData.cs

@@ -10,7 +10,7 @@ public abstract class AbstractChannelData
         /// Default: "browser" Indicates the type of channel interface being used to initiate the transaction.
         /// [Required]
         /// </summary>
-        public ChannelDataType? Channel;
+        public ChannelDataType Channel;
 
         protected AbstractChannelData(ChannelDataType channel)
         {

src/CheckoutSdk/Authentication/Standalone/POSTSessions/Requests/RequestASessionRequest/ChannelData/BrowserChannelData/BrowserChannelData.cs

@@ -30,7 +30,7 @@ public BrowserChannelData() : base(ChannelDataType.Browser)
         public bool JavaEnabled { get; set; }
 
         /// <summary>
-        /// Default:  true Boolean that represents the ability of the cardholder's browser to execute Javascript. Value
+        /// Default: true Boolean that represents the ability of the cardholder's browser to execute Javascript. Value
         /// is returned from the navigator.javascriptEnabled property. *only applicable/required for authentication
         /// performed using 3DS 2.2. If authentications results in processing on 2.1 or lower, this field will be
         /// disregarded.
@@ -93,17 +93,16 @@ public BrowserChannelData() : base(ChannelDataType.Browser)
         /// Default: "U" Indicates whether the 3DS Method successfully completed • Y = Successfully completed • N =
         /// Did not successfully complete • U = Unavailable (3DS Method URL was not present in the preperation response
         /// (PRes) message data for the card range associated with the cardholder's account number)
-        /// [Optional]
         /// 1 characters
         /// </summary>
-        public ThreeDsMethodCompletionType ThreeDsMethodCompletion { get; set; } = ThreeDsMethodCompletionType.U;
+        public ThreeDsMethodCompletionType? ThreeDsMethodCompletion { get; set; } = ThreeDsMethodCompletionType.U;
 
         /// <summary>
         /// Whether the Payment API is enabled for all parent frames. This is required for Google SPA support in hosted
         /// sessions.
         /// [Optional]
         /// </summary>
-        public bool IframePaymentAllowed { get; set; }
+        public bool? IframePaymentAllowed { get; set; }
 
         /// <summary>
         /// The raw Sec-CH-UA header value. This can improve Google SPA support.

src/CheckoutSdk/Authentication/Standalone/POSTSessions/Requests/RequestASessionRequest/Completion/AbstractCompletion.cs

@@ -6,7 +6,7 @@ namespace Checkout.Authentication.Standalone.POSTSessions.Requests.RequestASessi
     /// </summary>
     public abstract class AbstractCompletion
     {
-        public CompletionType? Type;
+        public CompletionType Type;
 
         protected AbstractCompletion(CompletionType type)
         {