Skip to content

Conversation

@armando-rodriguez-cko
Copy link
Contributor

@armando-rodriguez-cko armando-rodriguez-cko commented Jun 11, 2025

This pull request introduces significant updates to improve PHP version compatibility, modernize type safety in the codebase, and enhance CI workflows. The changes primarily focus on updating PHP dependencies, adding type hints, and restructuring workflows for better maintainability.

PHP Version Compatibility and Dependency Updates:

  • Updated the minimum PHP version requirement in composer.json and README.md to >=7.1 and added guidance for resolving compatibility issues with PHP 8.1+ by upgrading dependencies like phpunit/phpunit and guzzlehttp/guzzle. [1] [2]
  • Introduced conditional dependency installation in CI workflows to ensure compatibility with different PHP versions. [1] [2] [3]

Type Hinting and Code Modernization:

  • Added strict type hints (e.g., string, ?string, array) across multiple methods in ApiClient.php, CheckoutUtils.php, and EventsClient.php to improve type safety and readability. [1] [2] [3]
  • Refactored null checks and array handling to use modern PHP practices, such as strict comparisons and concise array initialization. [1] [2]

Continuous Integration (CI) Workflow Enhancements:

  • Updated .github/workflows files to expand PHP version testing matrix, remove outdated PHP 5.6-specific logic, and streamline dependency management steps. [1] [2] [3]
  • Added steps for generating and printing release versions in the build-release.yml workflow.

These changes ensure that the codebase is better aligned with modern PHP standards, improves compatibility with newer PHP versions, and enhances CI processes for better maintainability and reliability.

@armando-rodriguez-cko armando-rodriguez-cko requested a review from a team June 11, 2025 10:14
@armando-rodriguez-cko armando-rodriguez-cko force-pushed the feature/php71-minimum-requirement branch from ed1198d to c9f6fb1 Compare June 11, 2025 11:36
@Tobion
Copy link

Tobion commented Jun 16, 2025

PHP 7.1 is not supported anymore since a long time. Not even PHP 8.0 is anymore. So IMO the minimum version should be PHP 8.1 now.

@armando-rodriguez-cko armando-rodriguez-cko force-pushed the feature/php71-minimum-requirement branch 2 times, most recently from 03e6d51 to 0e18226 Compare June 18, 2025 12:11
@armando-rodriguez-cko armando-rodriguez-cko force-pushed the feature/php71-minimum-requirement branch from 0e18226 to c074dc1 Compare June 18, 2025 12:27
@armando-rodriguez-cko
Copy link
Contributor Author

@Tobion thank you for your comments, in new releases we will change the minimum version to 8.1

@armando-rodriguez-cko armando-rodriguez-cko merged commit 2655f38 into master Jun 23, 2025
4 checks passed
@armando-rodriguez-cko armando-rodriguez-cko deleted the feature/php71-minimum-requirement branch June 23, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecation notice on nullable properties in method signatures

4 participants