Skip to content

Refactor/reduce complexity v2 #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lalit-swain-cko merged 28 commits into from
Jan 21, 2026

Clean up admin JS and Flow terms helper for CodeQL

82d9c3f
Select commit
Loading
Failed to load commit list.
Merged

Refactor/reduce complexity v2 #402

Clean up admin JS and Flow terms helper for CodeQL
82d9c3f
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Jan 21, 2026 in 2m 21s

14 new alerts

New alerts in code changed by this pull request

  • 8 warnings
  • 6 notes

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 541 in flow-integration/assets/js/payment-session.js

See this annotation in the file changed.

Code scanning / CodeQL

Useless assignment to local variable Warning

The value assigned to phone here is unused.

Check warning on line 1927 in flow-integration/assets/js/payment-session.js

See this annotation in the file changed.

Code scanning / CodeQL

Useless conditional Warning

This use of variable 'flowContainer' always evaluates to true.

Check warning on line 2093 in flow-integration/assets/js/payment-session.js

See this annotation in the file changed.

Code scanning / CodeQL

Useless conditional Warning

This use of variable 'errorDisplayed' always evaluates to true.

Check warning on line 2128 in flow-integration/assets/js/payment-session.js

See this annotation in the file changed.

Code scanning / CodeQL

Useless conditional Warning

This use of variable 'error_message' always evaluates to true.

Check warning on line 3818 in flow-integration/assets/js/payment-session.js

See this annotation in the file changed.

Code scanning / CodeQL

Missing await Warning

Missing await. The value 'response' is always a promise.

Check warning on line 3874 in flow-integration/assets/js/payment-session.js

See this annotation in the file changed.

Code scanning / CodeQL

Useless conditional Warning

This use of variable 'normalizedResponse' always evaluates to true.

Check warning on line 3935 in flow-integration/assets/js/payment-session.js

See this annotation in the file changed.

Code scanning / CodeQL

Useless conditional Warning

This use of variable 'normalizedResponse' always evaluates to true.

Check warning on line 3955 in flow-integration/assets/js/payment-session.js

See this annotation in the file changed.

Code scanning / CodeQL

Useless conditional Warning

This use of variable 'nonceValue' always evaluates to true.

Check notice on line 285 in flow-integration/assets/js/payment-session.js

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable isSubscription.

Check notice on line 2276 in flow-integration/assets/js/payment-session.js

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable element.

Check notice on line 3511 in flow-integration/assets/js/payment-session.js

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable flowContainer.

Check notice on line 3577 in flow-integration/assets/js/payment-session.js

See this annotation in the file changed.

Code scanning / CodeQL

Semicolon insertion Note

Avoid automated semicolon insertion (90% of all statements in
the enclosing function
Loading
have an explicit semicolon).

Check notice on line 3795 in flow-integration/assets/js/payment-session.js

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable originalButtonText.

Check notice on line 4895 in flow-integration/assets/js/payment-session.js

See this annotation in the file changed.

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable rootElement.